Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation profile option to configure if failure to add gerelateerde zaken should result in warnings or errrors #287

Open
3 tasks
MLenterman opened this issue Mar 4, 2024 · 1 comment
Labels
feature New feature or request

Comments

@MLenterman
Copy link
Collaborator

It could be critical to the process to ensure that all gerelateerde zaken are added to a zaak, so throwing an error when adding gerelateerde zaken fails, will ensure data consistency by rolling back the whole action (not implemented yet). For other processes gerelateerde zaken could be not so important and it would be preferable to only give a warning when adding gerelateerde zaken fails, so that the process can move on without interruption.

There are also a variety of technical reason why adding a gerelateerde zaak could fail. For example: Adding a closed zaak as gerelateerde zaak without zaken.geforceerd_bijwerken permission scope, or adding a zaak as gerelateerde zaak that is not present in OpenZaak.

  • Add property to translation profile (example: "relatedCaseFailureBehavior": "warn/error")
  • Add testcases for both warn and error situations.
  • Default behavior should be error
@MLenterman MLenterman added the feature New feature or request label Mar 4, 2024
@MLenterman
Copy link
Collaborator Author

Should also include deletion of gerelateerdeZaken.

Not sure of making warnings/errors configurable is the right way to handle this issue. I'm also leaning towards using errorstores for these mutations. That would not roll back creeerZaak and not break updateZaak. It would be eventually consistent.

The reason for an errorstore would be the retry-ability and clear visibility in the Frank!Console. Almost all the causes for the mutations to fail are technical in nature. A major cause for mutations to fail is the gerelateerde zaak not being present on the ZGW side (yet). This requires the gerelateerde zaak to be added by an external system. After that the mutation should succeed with a retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant