Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create testcases for all the different ordering scenario's when closing a zaak #272

Closed
5 tasks
MLenterman opened this issue Feb 12, 2024 · 0 comments · Fixed by #291
Closed
5 tasks

Create testcases for all the different ordering scenario's when closing a zaak #272

MLenterman opened this issue Feb 12, 2024 · 0 comments · Fixed by #291
Labels
test test

Comments

@MLenterman
Copy link
Collaborator

MLenterman commented Feb 12, 2024

There is a lot of complexity surrounding the closing of a zaak. Most scenario's are already covered in the bigger end-to-end scenario's, but there are no asserts to validate the zaak closing behavior on those. We would like dedicated testcases for specifically testing the zaak closing behavior.

  • updateZaak sets einddatum before eindstatus is set. ZaakBrug closes the zaak by adding eindstatus with datumstatusgezet of einddatum. If in a later message eindstatus is set afterall, it should not be added a second time and no error should be thrown when the duplicate is detected.
  • updateZaak or actualiseerZaakStatus sets eindstatus without setting einddatum on the zaak. ZaakBrug simply adds given eindstatus.
  • updateZaak sets eindstatus and sets einddatum. ZaakBrug simply adds given eindstatus.
  • Same 3 default zaak closing scenario's, but now a resultaat is not present on the zaak yet when closing and there is no entry configured for the zaaktype in the translation profile in profiles.json. It should result in an error.
  • Same 3 default zaak closing scenario's, but now a resultaat is not present on the zaak yet when closing, but now there is a "endDateAndResultLastStatus" entry configured for the zaaktype in the translation profile in profiles.json. ZaakBrug should add a (dummy) resultaat of the configured resultaattype from the translation profile before it sets the eindstatus and closing the zaak should succeed. In a following updateZaak when resultaat is set afterall, the given resultaat should replace the injected (dummy) resultaat and not throw any errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant