Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors thrown in ForEachChildElementPipe should not be ignored #159

Closed
MLenterman opened this issue Sep 19, 2023 · 0 comments · Fixed by #111
Closed

Errors thrown in ForEachChildElementPipe should not be ignored #159

MLenterman opened this issue Sep 19, 2023 · 0 comments · Fixed by #111
Labels
bug Something isn't working

Comments

@MLenterman
Copy link
Collaborator

Currently a F!F bug is causing ForEachChildElementPipe to ignore errors in the child adapters when parallel=true. The most important part is to make sure that errors are not ignored anymore. A quickfix is to simply set parallel to false, but that impacts performances. Preferably find a way to keep parallel=true.

Mike had a possible solution in mind for this.
@MLenterman MLenterman added the bug Something isn't working label Sep 19, 2023
@MLenterman MLenterman linked a pull request Nov 15, 2023 that will close this issue
fix: errors thrown in ForEachChildElementPipe are being ignored #111
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: errors thrown in ForEachChildElementPipe are being ignored wearefrank/zaakbrug
1 participant
@MLenterman