-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mean read quality calculation #376
Comments
I think you are right and this is an error! I'll do my best to fix this soon, or you are welcome to open a pull request :) |
I notice the latest release is in Oct, 2023. Have the error been fixed now? |
Wouter, This comment is being added here as another item to possibly consider if/when revisiting the mean qscore. Not exactly this issue with the mean qscore, but having read your informative blog posts about them, I found an Issue on the dorado repo that might explain the qscore difference from what the basecaller reports and NanoMath/NanoPlot report. Issue is nanoporetech/dorado#937 It explains that, for whatever reason, the first 60 bases are skipped for the mean qual calc. Doing this does gives a qscore in agreement with basecaller values in my modest testing. This default of 60 is set in function get_mean_qscore_start_pos_by_model_name in file dorado/basecall/CRFModelConfig.cpp of the repo. Apparently models could set this as a value but usually do not, so 60 bases are typically skipped. I use your method -- thanks! -- to reattach a mean qscore after trimming to guide user filtering of reads and will continue to take all bases into account. These differences would seem to argue more for cropping low-qual beginning bases than ignoring them in a calculation. In any event, I thought I'd pass this along since I'd found the difference a puzzler. best, |
Hi Jim, Thanks for letting me know! Skipping some bases sounds entirely reasonable to me, dealing with issues because of adapter sequences and the start of the read. I might adopt that :-) Best, |
Wouter,
Yes, adapters had occurred to me as well. Though, after trimming, ignoring those bases seems something of a fiction doesn't it (and I wonder how low qual prefixes affect OLC style algorithms).
Perhaps an option (options, I know, ugh) for nanopore or complete qscore. With the popularity of your programs it would bring visibility to this issue,
which I think would be of value to the community.
best,
Jim
… On 09/16/2024 5:04 AM PDT Wouter De Coster ***@***.***> wrote:
Hi Jim,
Thanks for letting me know! Skipping some bases sounds entirely reasonable to me, dealing with issues because of adapter sequences and the start of the read. I might adopt that :-)
Best,
Wouter
—
Reply to this email directly, view it on GitHub #376 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AELSO4JFD7LQVVYN4LTXPJLZW3COBAVCNFSM6AAAAABKUSPVVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSG4ZDMNRWGI.
You are receiving this because you commented.Message ID: ***@***.***>
|
The mean read quality is calculated by:
In Nanomath, for step 1, the mean phred score of each read is interpreted as an
int
instead of afloat
.Does this conversion not introduce an error in the mean read quality?$P = 10^{-\frac{10}{Q}}$ , it should be 0.02089.
If I have a read with a mean quality of 16.8, the script converts it to 16 and the probability becomes 0.02512.
But according to the formula
Using this test file (columns are read id, length and mean quality) and without converting to
int
:The mean read quality 13.22437.
If I convert the scores to
int
:The mean read quality is 12.71993, the same as Nanoplot reports (see attached file).
NanoStats.txt
Is there a reason to convert the mean score of each read to
int
before calculating the probabilities?The text was updated successfully, but these errors were encountered: