Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #152 Show ST4 badges #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #152 Show ST4 badges #161

wants to merge 1 commit into from

Conversation

gerardroche
Copy link

@gerardroche gerardroche commented Jun 1, 2023 •
edited
Loading

  • Show ST4 badges for packages that support ST4.
    Previously no badge was shown for packages that support ST4. This fixes "ST3" badge shown for packages that also support ST4 #152

  • Make ST4 badges green like the ALL badge.
    Previously only the ALL badge was green, but I think the latest version should also be green.

  • Show ALL badge on package list.
    Previously no badge was shown on the listing page for packages that support all versions.

Fix #152

Q. Do I need to include the app.css and app.js files?

Listing before

listing-before

Listing after

listing

Package page before

package-before

Package page after

package-after

@FichteFoll
Copy link
Contributor

FichteFoll commented Jun 1, 2023 •
edited
Loading

I think this needs a bit of a discussion. Technically, this is a correct approach, but I'd argue that supporting the latest version is the expected behavior and does not need to be highlighted explicitly and ST2 support will be removed on the next PC release (finally), so I propose the following:

  1. package supports ST 3 and ST 4: no badge
  2. package supports ST 4 only: has ST4 badge or has "no ST3" badge
  3. package supports ST 3 only: has ST3 badge

This is basically the same as when we had ST2 and ST3 in parallel. Since ST2 is still technically supported by the latest version (though not really?) and we still have packages listed for it, I would also be ok with showing both ST3 and ST4 badges for the secondfirst case here until that is finalized. However, I don't think we need "ALL".

@gerardroche gerardroche force-pushed the fix-152-st4-badges branch from 1026ed8 to c841ce8 Compare June 1, 2023 16:00
@gerardroche
Fix wbond#152 Show ST4 badges
c841ce8 
- Show ST4 badges for packages that support ST4
- Make ST4 badges green like the ALL badge
- Show ALL badge on package list

Fix wbond#152
@gerardroche
Copy link
Author

gerardroche commented Jun 1, 2023 •
edited
Loading

If we do away with the all then the st4 badge doesn't need to be green. The only reason I made that green is because the ALL tag seem to shadow the ST4 one which I don't think is right.

  • package supports ST 3 and ST 4: no badge
    Yes. Because this kind-of implies ALL. ST2 is so old that ST3 and ST4 is pretty mush ALL.
  • package supports ST 4 only: has ST4 badge or has "no ST3" badge
    I think just the ST4 tag for this one.
  • package supports ST 3 only: has ST3 badge
    Yes.

I think that makes sense and is much cleaner. Will I go ahead and make that change?

@FichteFoll
Copy link
Contributor

Will I go ahead and make that change?

SGTM. I can't merge or deploy any of this, though, since only wbond has the permissions to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FichteFoll FichteFoll FichteFoll requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"ST3" badge shown for packages that also support ST4
2 participants
@gerardroche @FichteFoll