GitHub package marked as “missing” if a necessary tag is not one of the first 100 returned by the API

[Thom1729]

Supersedes #142.

packagecontrol.io/app/lib/package_control/clients/github_client.py

Line 93 in a0a9420

tags_url = self._make_api_url(user_repo, '/tags?per_page=100')

The GitHub client only looks at the first 100 tags. In most cases, this should work fine because the response seems to be sorted in reverse lexicographical order, so the newest tag should usually be the first. However, if a repository uses multiple tag prefixes, such as v and st3-, then it might fail to find the latest tag for one of those prefixes.

This happened recently for JS Custom. ST3-compatible tags use the st3 prefix, but there were more than 100 tags using the v prefix, so all ST3 tags were pushed to the second page. This caused the package to be marked as missing. (Thom1729/Sublime-JS-Custom#124) I fixed the immediate problem by deleting some older tags. The crawler soon picked it up and JS Custom is back online.

Probably, the GitHub client will need to fetch every page of tags in order to avoid this bug completely. The GitHub API call doesn't seem to permit custom sorting or filtering by prefix, and the default sort is technically unspecified. Alternatively, the client could assume that the result is sorted and stop fetching when it finds a tag for each prefix it's looking for.

Related: #41.