Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GutterColor slows down opening Install command panel #1646

Closed
eugenesvk opened this issue Jul 21, 2023 · 4 comments
Closed

GutterColor slows down opening Install command panel #1646

eugenesvk opened this issue Jul 21, 2023 · 4 comments

Comments

@eugenesvk
Copy link

eugenesvk commented Jul 21, 2023

While troubleshooting #1645 I've discovered another puzzling issue: installing and using (having it active in an opened file) https://github.com/ggordan/GutterColor increases the time to open the Package Control: Install package command panel:

  • ~0.7 sec with all packages disabled in the settings
  • ~2.1 sec with ONLY GutterColor active (and highlighting the current file)

I realize it's an old plugin, but still believe it should not have these kidns of side effects on this core ST package

Package Control: Fetching list of available packages and libraries
  Platform: osx-x64
  Sublime Text Version: 4150
  Package Control Version: 4.0.0-beta4

nothing is going on in the log, same with and without the plugin (there is a bunch of network calls on the first Install command, )

(also checked within the safe mode with just two packages isntalled: package control and guttercolor and a custom theme, ignoring GutterColor restores performance)

@deathaxe
Copy link
Collaborator

I don't see any relations or reasons for such delays, nor can I reproduce them with GuterColor installed on Windows 11.

Package Control already uses dedicated threads to run background tasks, instead of relying on ST's worker thread, to not be delayed by or delay other plugins.

And it runs on another plugin_host.

@eugenesvk
Copy link
Author

I don't see the connect either, yet it's there, the safe mode test with a single packages proves it
Was Gutter Color active and showing gutter colors on the opened file when you tried to run the Install command?

@deathaxe
Copy link
Collaborator

Tried with its test.css open - no delay.

@deathaxe
Copy link
Collaborator

If a plugin gets slowed down by another one running on a separate plugin_host, the only possible reason may be related with inter-process-communication or with API thread safety mechanisms.

Package Control downloads and parses information in a dedicated background thread with little to no application of sublime API calls until the final step of creating the quick panel with the list of pre-built items.

There's nothing to do to run it more independently.

@deathaxe deathaxe closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants