-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rhsm_config (still not working) #117 #120
Comments
I ran into this too, and I found that the regex added in e12d8a9 was not working on RHEL6 and RHEL7, but it does work on RHEL8 and RHEL9. In case of RHEL8 or RHEL9, the output of the
with a space as separator. In case of RHEL6 or RHEL7 the output of the
with an '=' as separator. Because the code to parse this output reads: puppet-subscription_manager/lib/puppet/provider/rhsm_config/subscription_manager.rb Line 244 in a8bddf2
The regex expects the separator to be a single space only. If the line is altered to Note: I did not test on RHEL5, that OS is now well beyond extended support, so I don't see a reason to still support it. |
Opened #121 to fix this issue. |
@waveclaw, can you please shine your light on this? The fix is really easy. |
No, it's not 'really easy.' This is not a 'just update the regex' situation. If you had provided an actual merge-request you would have seen the breakage on the unit test. I have to re-write the provider to support that small looking change plus additional OS detection code. That has knock-on effects up to forcing a new major release when the state parsing changes in any way. I'm mostly supporting Oracle, Alma and Rocky Linux. Behavior is different but the OS detection finds it as RedHat. That is obviously a problem for legacy versions like 6 and current but older releases like 7. I'm probably faced with checking if subscription-manager is 1.25 or later as that brought in the new 'equal-less' options parsing without pushing the major release of a backwards-incompatible API change. |
Sorry for short cutting the solution, I thought I did the right thing by creating PR, but apparently I didn't. I'm normally using Gitlab or Bitbucket on prem, so I'm missing the experience on Github. I'd love to see a unit test against my proposed change, so how can I achieve that? I'm very willing to fix this properly, as it still affects our environment. |
The config still does not change when using rhsm_config:
From a debug-run:
It seems that the cmds[:apply] is nill. Tested it with a debug and Puppet.debug line in the code and it is empty. No idea how to fix it.
puppet-subscription_manager/lib/puppet/provider/rhsm_config/subscription_manager.rb
Line 43 in a8bddf2
The text was updated successfully, but these errors were encountered: