Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Property (_InnerSphereOffset) exceeds maximum allowed array size (7644). Cap to (1023). #1155

Open
2 tasks done
klauskobald opened this issue Jul 25, 2024 · 6 comments
Labels

Comments

@klauskobald
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Have you checked the documentation to resolve your problem?

  • I have read the linked documentation and could not resolve my issue.

Current Behavior

I am studying logfiles that the app is sending to my server from all my users and I see some concerning entries like this:

Warning Property (_InnerSphereOffset) exceeds maximum allowed array size (7644). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

It's 1000s of lines once it is happening. It is not happening allways but on a lot of devices of all kinds. iOS, Android.

I do not see this in the editor. It seems to be happening since a while.

Expected Behavior

no warning

Steps To Reproduce

n/a

Unity Version

2021.3.40

Crest Version

4.19

Render Pipeline

Universal

Editor or Standalone

Standalone

Environment

misc

Anything else?

No response

@daleeidd
Copy link
Collaborator

Are you seeing Crest: There are too many instances of SphereWaterInteraction. A maximum of 1023 instances is supported. in the logs?

@klauskobald
Copy link
Author

no. There are a maximum of 4 in the scene for catamaran and 2 for the monohull boat.

@klauskobald
Copy link
Author

klauskobald commented Jul 28, 2024

I see that there is always this more warnings:
2024-07-27T19:13:13Z Warning Property (_Velocity) exceeds maximum allowed array size (3284). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

2024-07-27T19:13:13Z Warning Property (_Radius) exceeds maximum allowed array size (3284). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

2024-07-27T19:13:13Z Warning Property (_InnerSphereOffset) exceeds maximum allowed array size (3284). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

2024-07-27T19:13:13Z Warning Property (_InnerSphereMultiplier) exceeds maximum allowed array size (3284). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

2024-07-27T19:13:13Z Warning Property (_LargeWaveMultiplier) exceeds maximum allowed array size (3284). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

2024-07-27T19:13:13Z Warning Property (_DisplacementAtInputPosition) exceeds maximum allowed array size (3284). Cap to (1023).
Crest.SphereWaterInteraction:SubmitDraws(LodDataMgr, Int32, CommandBuffer)
Crest.LodDataMgrPersistent:BuildCommandBuffer(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildLodData(OceanRenderer, CommandBuffer)
Crest.BuildCommandBuffer:BuildAndExecute()
Crest.OceanRenderer:RunUpdate()

It seems to be a race condition problem at startup of the scene. I cannot see if the user is killing the app. But the next launch of the app does not show the warning again.

@daleeidd
Copy link
Collaborator

Can you apply this patch and let me know if things improve: master...fix-swi-property-leak

@klauskobald
Copy link
Author

I will check. At least I see the warnings also in the editor sometimes.

@klauskobald
Copy link
Author

It seems the warning only occurs when user changes the boats and instances are created / deleted. The game is halted at that time by setting the framerate to 0. So maybe that has an impact. I am still investigating, but it might not be a big problem at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants