Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dye Desal Flowsheet Parameters #1528

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2aa08a0
Correct costing in dye desalination flowsheet
MarcusHolly Sep 3, 2024
b110d0d
Remove negative signs from costs in the results display
MarcusHolly Sep 3, 2024
041ec42
Address Adam's comment and a few minor issues
MarcusHolly Sep 4, 2024
36bb363
Address failure
MarcusHolly Sep 4, 2024
3a2b106
Merge branch 'main' into dye_desal_update
MarcusHolly Sep 4, 2024
ce179cb
Correct typo in nanofiltration ZO costing
MarcusHolly Sep 10, 2024
f7b0105
Minor changes to parameter values
MarcusHolly Sep 10, 2024
e3c19b1
Merge branch 'main' into dye_desal_update
MarcusHolly Sep 10, 2024
4b3ed9e
Update dye desal sweep
MarcusHolly Sep 11, 2024
8d236af
Update dye desal tests
MarcusHolly Sep 20, 2024
a1f827a
Merge branch 'main' into dye_desal_update
MarcusHolly Sep 20, 2024
47ce925
Remove visualization from dye sweep
MarcusHolly Sep 20, 2024
f7767fa
Update NF ZO test
MarcusHolly Sep 22, 2024
93977df
Address pylint issue
MarcusHolly Sep 23, 2024
22dfc3d
Have GAC use regular dye disposal cost
MarcusHolly Sep 23, 2024
67dc007
Update test based on last commit
MarcusHolly Sep 23, 2024
bee127e
Add config options for dye revenue and brine revenue
MarcusHolly Sep 24, 2024
80ecc03
Comment out print statements
MarcusHolly Sep 25, 2024
3e56b85
Update dye desal sweep
MarcusHolly Sep 25, 2024
6ee28e4
Update how LCOT_no_revenue is calculated
MarcusHolly Sep 26, 2024
baaa6c3
Clean up flowsheet
MarcusHolly Oct 4, 2024
7077be8
Merge branch 'main' into dye_desal_update
MarcusHolly Oct 4, 2024
ddd603f
Merge branch 'main' into dye_desal_update
MarcusHolly Oct 11, 2024
210e3b9
Merge branch 'main' into dye_desal_update
MarcusHolly Oct 25, 2024
d38900c
Update capital recovery factor for RO_costing
MarcusHolly Oct 25, 2024
0e13d23
Add scaling factors for costing variables
MarcusHolly Oct 25, 2024
6ef0385
Remove badly scaled var list from flowsheet
MarcusHolly Oct 31, 2024
f2868e6
Merge branch 'main' into dye_desal_update
MarcusHolly Oct 31, 2024
e2e24e6
Merge branch 'main' into dye_desal_update
MarcusHolly Nov 13, 2024
9b0d762
Update rHGO NF parameter values
MarcusHolly Nov 15, 2024
90a2c08
Change cost units from USD_2020 to USD_2023
MarcusHolly Nov 15, 2024
4a6ef37
Add calculations for dye removal and adsorption capacity into flowsheet
MarcusHolly Nov 18, 2024
0278d82
Update testing
MarcusHolly Nov 19, 2024
4bb2a59
Update nanofiltration ZO tests
MarcusHolly Nov 20, 2024
e7aacf0
Address merge conflicts
MarcusHolly Nov 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions watertap/data/techno_economic/nanofiltration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,23 +114,23 @@ rHGO_dye_rejection:
value: 0.2
units: 1/year
recovery_frac_mass_H2O:
value: 0.83
value: 0.90
units: dimensionless
default_removal_frac_mass_comp:
value: 0
units: dimensionless
removal_frac_mass_comp:
dye:
value: 0.9917
value: 0.991
units: dimensionless
constituent_longform: Dye
tds:
value: 0.2117357
value: 0.145255
units: dimensionless
constituent_longform: Total Suspended Solids (TSS)
constituent_longform: Total Dissolved Solids (TDS)
applied_pressure:
value: 7 # corresponds to default of 100 psi
units: bar
water_permeability_coefficient:
value: 105
value: 100
units: liters/m^2/hour/bar
Loading
Loading