add crystallizer flowsheet #1482

ElmiraShamlou · 2024-08-20T18:52:57Z

add crystallizer flowsheet

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

adam-a-a · 2024-09-11T13:47:21Z

watertap/flowsheets/crystallization/Crystallizer_MVR.py

+    m.fs.properties = props.NaClParameterBlock()
+    m.fs.properties_nacl = props_nacl.NaClParameterBlock()


Why use two separate NaCl property models? Any reason not to use NaCl with temp dependence by itself?

The key difference between the two property packages is that the crystallizer-specific package includes additional solid and vapor phases, which are not present in the other unit models.

Makes sense--I should've double-checked the imports.

adam-a-a · 2024-09-11T13:49:10Z

watertap/flowsheets/crystallization/Crystallizer_MVR.py

+from idaes.core import UnitModelCostingBlock
+
+from watertap.property_models.unit_specific import cryst_prop_pack as props
+from watertap.unit_models.Crystallizer_revised import Crystallization


I am interested to see how the revised form differs from the original. For one, I would prefer to have the revised version condensed within the original, accessible through config options, assuming there is considerable overlap in code. Waiting to see this unit model file to determine that.

I suppose you can get rid of Crystallizer_revised and just use the revised original now, right?

…l file

adam-a-a

Here are some initial comments from a first pass

adam-a-a · 2024-10-25T02:35:48Z

watertap/costing/unit_models/crystallizer.py

@@ -93,7 +93,7 @@ def build_crystallizer_cost_param_block(blk):
    )

    costing = blk.parent_block()
-    costing.register_flow_type("steam", blk.steam_cost)
+    #costing.register_flow_type("steam", blk.steam_cost)


delete commented code

adam-a-a · 2024-10-25T02:37:57Z

watertap/costing/unit_models/crystallizer.py

-    blk.costing_package.cost_flow(
-        pyo.units.convert(
-            (
-                blk.unit_model.magma_circulation_flow_vol
-                * blk.unit_model.dens_mass_slurry
-                * Constants.acceleration_gravity
-                * blk.costing_package.crystallizer.pump_head_height
-                / blk.costing_package.crystallizer.efficiency_pump
-            ),
-            to_units=pyo.units.kW,
-        ),
-        "electricity",
-    )
-
-    blk.costing_package.cost_flow(
-        pyo.units.convert(
-            (blk.unit_model.work_mechanical[0] / _compute_steam_properties(blk)),
-            to_units=pyo.units.m**3 / pyo.units.s,
-        ),
-        "steam",
-    )


Curious about why these lines are being deleted. I probably didn't look closely enough, but have they been moved elsewhere or completely removed? And why?

@adam-a-a They are removed as we integrate the steam heater, pump, and other essential components into the full FC crystallizer flowsheet. Therefore, the flow rates of the steam and recycle streams, along with their associated costs, are incorporated within the cost calculations of the steam heater and pump unit models.

@ElmiraShamlou but removing this hinders whoever wants to use the combined unit we had previously.

Maybe what we need is a configuration argument that determines the mode the user wants (broken down or combined), and then adds the necessary equations for each case?

adam-a-a · 2024-10-25T02:38:56Z

watertap/costing/unit_models/crystallizer.py

@@ -215,72 +194,3 @@ def cost_crystallizer_by_volume(blk):
        )
    )
    _cost_crystallizer_flows(blk)
-
-
-def _compute_steam_properties(blk):


Same question here, except it makes more sense immediately as to why we wouldn't want/need this in a costing module

adam-a-a · 2024-10-25T02:40:09Z

watertap/flowsheets/crystallization/Crystallizer_MVR.py

+    m.fs.properties = props.NaClParameterBlock()
+    m.fs.properties_nacl = props_nacl.NaClParameterBlock()


Makes sense--I should've double-checked the imports.

adam-a-a · 2024-10-25T02:41:00Z

watertap/flowsheets/crystallization/Crystallizer_MVR.py

+    m.fs.distillate = Product(property_package= m.fs.properties_vapor)
+
+
+    # unit models: steam heater, mixer, pump, crystalizer, compressor, separator


Suggested change

# unit models: steam heater, mixer, pump, crystalizer, compressor, separator

# unit models: steam heater, mixer, pump, crystallizer, compressor, separator

adam-a-a · 2024-10-25T03:01:17Z

watertap/unit_models/crystallizer.py

-        )
-
+        """
+            self.work_mechanical = Var(


I'm surprised to see no tests fail for the crystallizer unit especially since no changes were made to the test file.

The tests are failing, and I'm revising them to align with the recent changes.

adam-a-a · 2024-10-25T03:04:24Z

watertap/flowsheets/crystallization/crystallizer_live_steam_with_condenser_chiller.py

+
+    optimize_set_up(m)
+
+    #interval_initializer(m)


I am guessing that an InfeasibleConstraint exception (or something like that) arises when using the interval initializer.

adam-a-a · 2024-10-25T03:06:29Z

watertap/flowsheets/crystallization/crystallizer_live_steam_with_condenser_chiller.py

@@ -0,0 +1,508 @@
+#################################################################################


Next step is to add (1) a test file for this flowsheet and (2) documentation for this flowsheet in this section: https://watertap.readthedocs.io/en/latest/technical_reference/flowsheets/index.html

adam-a-a · 2024-10-25T03:06:40Z

watertap/flowsheets/crystallization/Crystallizer_MVR.py

@@ -0,0 +1,444 @@
+#################################################################################


Next step is to add (1) a test file for this flowsheet and (2) documentation for this flowsheet in this section: https://watertap.readthedocs.io/en/latest/technical_reference/flowsheets/index.html

adam-a-a · 2024-10-25T03:06:57Z

watertap/flowsheets/crystallization/Crystallizer_MVR.py

+#from watertap.core.util.model_debug_mode import activate
+#activate()


ElmiraShamlou added 2 commits August 20, 2024 14:48

add crystallizer flowsheet

f52db5e

modifications

2b16d2e

ElmiraShamlou marked this pull request as draft August 21, 2024 12:33

ElmiraShamlou added 3 commits August 22, 2024 07:18

modifies costig

bd85f8a

modifies steam heater

deef8f9

modifies chiller

f4d56c0

ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 22, 2024

ksbeattie assigned ElmiraShamlou Aug 22, 2024

ksbeattie requested review from OOAmusat, carson-tucker and adam-a-a August 22, 2024 20:15

adam-a-a reviewed Sep 11, 2024

View reviewed changes

ElmiraShamlou added 2 commits September 11, 2024 11:05

add revised crystallizer model

b790eab

add purge to MVR config

45d86d0

kurbansitterley mentioned this pull request Sep 17, 2024

Multi-effect crystallizer unit model watertap-org/watertap-reflo#121

Merged

4 tasks

ElmiraShamlou added 2 commits October 1, 2024 11:38

add chiller for crystallizer vapor condensation

2358454

transfer revised crystallizer model to the original crystallizer mode…

eb4acd6

…l file

adam-a-a reviewed Oct 25, 2024

View reviewed changes

ElmiraShamlou mentioned this pull request Oct 28, 2024

MCAS w/generic crystallizer #1487

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add crystallizer flowsheet #1482

add crystallizer flowsheet #1482

ElmiraShamlou commented Aug 20, 2024 •

edited

Loading

adam-a-a Sep 11, 2024

ElmiraShamlou Sep 12, 2024

adam-a-a Oct 25, 2024

adam-a-a Sep 11, 2024

adam-a-a Oct 25, 2024

adam-a-a left a comment

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

ElmiraShamlou Oct 28, 2024

OOAmusat Oct 29, 2024

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

ElmiraShamlou Oct 28, 2024

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

adam-a-a Oct 25, 2024

		m.fs.properties = props.NaClParameterBlock()
		m.fs.properties_nacl = props_nacl.NaClParameterBlock()

		m.fs.distillate = Product(property_package= m.fs.properties_vapor)


		# unit models: steam heater, mixer, pump, crystalizer, compressor, separator

		@@ -0,0 +1,508 @@
		#################################################################################

		@@ -0,0 +1,444 @@
		#################################################################################

		#from watertap.core.util.model_debug_mode import activate
		#activate()

add crystallizer flowsheet #1482

Are you sure you want to change the base?

add crystallizer flowsheet #1482

Conversation

ElmiraShamlou commented Aug 20, 2024 • edited Loading

Legal Acknowledgement

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adam-a-a left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ElmiraShamlou commented Aug 20, 2024 •

edited

Loading