Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requests for OLI API #1328

Open
12 tasks
veccp opened this issue Mar 14, 2024 · 1 comment
Open
12 tasks

Feature Requests for OLI API #1328

veccp opened this issue Mar 14, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request oli Priority:Normal Normal Priority Issue or PR

Comments

@veccp
Copy link
Contributor

veccp commented Mar 14, 2024

Description

This issue tracks tasks to help with OLI Cloud API development, in approximate order of priority.
_Tasks last updated: June 28, 2024 by @adam-a-a _

  • Add a concentration_factor_survey function to make it easier to quickly run OLI calculations that simulate water recovery and elevated concentrations (and associated scaling tendencies)
  • Resolve units issues preventing a future concentration_factor_survey from working Enable concentration factor survey in OLI API #1458
  • Enable bubblepoint function to work without error Fix bubblepoint function and unit inconsistency in OLI API #1388
  • Enable dewpoint, vapor-amount, vapor-fraction, and isochoric functions to work without error
  • Asynchronous calls to the API (Parallel data queueing for OLIApi #1303)
  • Sequential surveys, e.g., chemical additions followed by pH adjustment
  • Improve test coverage (>80%); Add more rigorous testing to cover all existing functionality (including exception handling)
  • Improve CredentialManager class (Improve OLI API Credential Manager #1300)
  • Interface with WaterTAP and simplify usage
  • Docstring clarity and consistency with rest of WaterTAP (imports, structure, naming conventions, etc.)
  • Add rules for liquid2 (non-aqueous liquid) phase
  • Add features for OLI Flowsheet
@veccp veccp added the enhancement New feature or request label Mar 14, 2024
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 21, 2024
@adam-a-a
Copy link
Contributor

adam-a-a commented Mar 22, 2024

Adding an item here that I think should be a priority before making major changes or additions to the API:

  • Add more rigorous testing to cover all existing functionality (including exception handling)

@ksbeattie ksbeattie added the oli label Apr 25, 2024
@adam-a-a adam-a-a assigned adam-a-a and unassigned veccp Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request oli Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants