-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chem Softening for Stability and Flowsheet Use #124
Merged
zacharybinger
merged 66 commits into
watertap-org:main
from
kurbansitterley:update_chem_soft
Sep 27, 2024
Merged
Update Chem Softening for Stability and Flowsheet Use #124
zacharybinger
merged 66 commits into
watertap-org:main
from
kurbansitterley:update_chem_soft
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to update the test for modified costing equations. |
…lues for target eff
…/watertap-reflo into pr/kurbansitterley/124
…/watertap-seto into update_chem_soft
…/watertap-reflo into pr/kurbansitterley/124
…/watertap-seto into update_chem_soft
…carbonate_hardness
zacharybinger
approved these changes
Sep 27, 2024
MuktaHardikar
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending issues:
- Add outlet alkalinity calculation
- Add method to select softening procedure based on inlet composition
Memorialized this in #129 so it doesn't get buried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues should be fixed after troubleshooting for KBHDP case study:
Expr_if
ineq_CO2_first_basin
Expr_if
will remedy this.