Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chem Softening for Stability and Flowsheet Use #124

Merged
merged 66 commits into from
Sep 27, 2024

Conversation

kurbansitterley
Copy link
Contributor

@kurbansitterley kurbansitterley commented Sep 9, 2024

A few issues should be fixed after troubleshooting for KBHDP case study:

  • adding isobaric constraints for waste and effluent
  • adding isothermal constraints for waste and effluent
  • use Expr_if in eq_CO2_first_basin
    • if total concentrations of Mg and Ca (as CaCO3) are higher than alkalinity, you will get negative CO2 required. This Expr_if will remedy this.
  • fix a few errors where e.g., Ca as CaCO3 was used when it was supposed to be Ca Hardness
  • convert some of Sharma costing equations to C = A*x**b where necessary/appropriate
  • cost per reactor, then multiply by number of reactors (mixer and floc)

@kurbansitterley
Copy link
Contributor Author

still need to update the test for modified costing equations.

Copy link
Collaborator

@MuktaHardikar MuktaHardikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending issues:

  1. Add outlet alkalinity calculation
  2. Add method to select softening procedure based on inlet composition

@zacharybinger zacharybinger merged commit 4a315bf into watertap-org:main Sep 27, 2024
18 checks passed
@kurbansitterley
Copy link
Contributor Author

Approving pending issues:

  1. Add outlet alkalinity calculation
  2. Add method to select softening procedure based on inlet composition

Memorialized this in #129 so it doesn't get buried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High Normal Priority Issue or PR treatment_models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants