Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown test failure #84

Open
adam-a-a opened this issue Oct 31, 2023 · 5 comments
Open

Unknown test failure #84

adam-a-a opened this issue Oct 31, 2023 · 5 comments

Comments

@adam-a-a
Copy link
Contributor

These started sprouting up, coincidentally while I was adding empty commits to #77, so I originally thought the issue was related:
image

Unclear what the real issue is. The current fix is to just rerun the checks, but that isn't ideal.

@kurbansitterley
Copy link
Contributor

seeing this in #85 also

@dguittet
Copy link
Contributor

I'll try to dig into it

@adam-a-a
Copy link
Contributor Author

adam-a-a commented Feb 1, 2024

Potential approach: Ask @bknueven and @lbianchi-lbl ! =)

@adam-a-a
Copy link
Contributor Author

adam-a-a commented Feb 1, 2024

Note, this seems to happen when creating surrogate models via pysmo on data generated via pysam (I think). @dguittet would be able to provide more details.

@adam-a-a
Copy link
Contributor Author

adam-a-a commented Feb 6, 2024

Now that testing the trough surrogate has been resolved (i.e., eliminated random sampling for consistent test results in PR #104 ), I wonder if this issue here will still show up. If anyone (@dguittet , @kurbansitterley , @MuktaHardikar @zacharybinger , @Zhuoran29 ) comes across this error again, can you please note that here?

If we don't see this issue pop up again in the near-term, I would guess that the failure was attributed to the random sampling taking place for testing/training data to create surrogates. In that case, we could close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants