Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add examples and benchmarks for other PhreeqcDatabases #13

Open
avdudchenko opened this issue Oct 31, 2024 · 0 comments
Open

Need to add examples and benchmarks for other PhreeqcDatabases #13

avdudchenko opened this issue Oct 31, 2024 · 0 comments

Comments

@avdudchenko
Copy link
Contributor

Current testing is done exclusivly with pitzer.dat, but it was observed that other databases could produce unexpected results. This was partly due to commission of pH balance on any of block with exact speciation and observed for llnl.dat and wateq4f database. This would typically result in unexpected pH changes for exact speciated block ( adding acid increases pH rather then drops it).

The PR on ph Balance should solve the problem, but needs explicit benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant