Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image upload to user profile page #466

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrQubo
Copy link
Member

@MrQubo MrQubo commented May 7, 2021

Not #319 but it's at least something.


This change is Reviewable

wwwapp/views.py Show resolved Hide resolved
@MrQubo
Copy link
Member Author

MrQubo commented May 7, 2021

Similar CI error as in #465. 0.o

Copy link
Member

@krzys-h krzys-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't allow uploads in the profile description by design (you don't really need it, and it would be the only non-admin upload form at the time - with all the security implications of that. Not really true anymore though ¯\(ツ)/¯)

I'm still not convinced we need it. @cytadela8 wanted a field in the profile, not image uploads on the profile page. We already have a problem with the workshop pages having images pasted in random places instead of one designated spot, which usually doesn't work on mobile (and that is where most of users browsing these pages are). We should work on fixing that, instead of making it worse by introducing the same problem elsewhere.

@cytadela8
Copy link
Member

It's a good point about this not working great for mobile!

@krzys-h krzys-h marked this pull request as draft April 26, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants