Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional snippets excluding DataClassification / ApplicationArea ? #267

Open
fvet opened this issue Dec 2, 2022 · 1 comment
Open

Comments

@fvet
Copy link

fvet commented Dec 2, 2022

@waldo1001 Not sure if issues are actively monitored here, but wanted to get your opinion on the below ;)

Since AL runtime 10 some properties are no longer mandatory.

  • DataClassification on table fields is no longer needed, if specified on table level.
  • ApplicationArea on page controls is no longer needed, if specified on page level.

Some of the page field / table field related snippets contain default code for setting the DataClassification / ApplicationArea properties.

It would be great if - based on the AL runtime version - these settings could be removed / no longer suggested as part of the snippet.

One of the complexities is that these properties are only redundant on table / page objects and NOT on table extension / page extension objects.


PS: We're using following rules to discover / cleanup redundant properties.

https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0019
https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0020

@waldo1001
Copy link
Owner

waldo1001 commented Dec 5, 2022

@fvet ,

Valid!
I could do this, but I can' t do this based on runtime - it's "just" a snippet.

So - doing it "now" - would that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants