Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some generic type arguments #1365

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add some generic type arguments #1365

merged 1 commit into from
Jan 22, 2024

Conversation

msridhar
Copy link
Member

Everything seems to compile fine with these changes. Let's us get rid of a rawtypes suppression.

@msridhar msridhar requested a review from liblit January 22, 2024 20:46
@msridhar msridhar enabled auto-merge (squash) January 22, 2024 20:46
@github-actions GitHub Actions
Copy link

Test Results

  572 files  ±0    572 suites  ±0   3h 38m 46s ⏱️ + 23m 33s
  731 tests ±0    714 ✅ ±0  17 💤 ±0  0 ❌ ±0 
3 539 runs  ±0  3 452 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit 27b0df4. ± Comparison against base commit f7f4df0.

liblit
liblit approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@liblit liblit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for incremental progress toward cleaner code!

@msridhar msridhar merged commit 675cee8 into wala:master Jan 22, 2024
10 checks passed
@msridhar msridhar deleted the add-some-type-arguments branch January 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liblit liblit liblit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @liblit