-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the copied modules from scipy #11
Comments
Thanks for taking an interest in pyWAFO. There are several things that have to be fixed regarding the installation and packaging:
I see you made some changes in the scipy branch of your fork, feel free to send the changes as pull requests here. |
Appoligies....I totally missed that PR. |
No problem. I try to always open an issue and a corresponding PR to that issue. Some people prefer that way for better bookkeeping. |
Very nice indeed, thanks! |
Hi @davidovitch, Just checking the reason for closing this. The developers have no interest in dropping the copied modules from scipy to a scipy import? |
ok, my bad, I was a bit quick, I thought this was related to PR #10 (which has been merged), but now I understand it isn't. Re-opening. |
No problem. Once things stabilize and the tests are running I will try to implement this change. |
... and make
scipy
a dependency.This will make it easier to manage packaging and versioning.
The text was updated successfully, but these errors were encountered: