Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the copied modules from scipy #11

Open
ocefpaf opened this issue Sep 8, 2015 · 8 comments
Open

Drop the copied modules from scipy #11

ocefpaf opened this issue Sep 8, 2015 · 8 comments

Comments

@ocefpaf
Copy link
Contributor

ocefpaf commented Sep 8, 2015

... and make scipy a dependency.

This will make it easier to manage packaging and versioning.

@davidovitch
Copy link
Member

Thanks for taking an interest in pyWAFO. There are several things that have to be fixed regarding the installation and packaging:

  • have the same directory structure as pandas/numpy/scipy etc
  • setup.py is broken, make sure all extensions will be build
  • upload to pypi, make wheels
  • conda package (optional)

I see you made some changes in the scipy branch of your fork, feel free to send the changes as pull requests here.

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Sep 20, 2015

conda package (optional)

I create a conda package here. It is easier than wheels.

I see you made some changes in the scipy branch of your fork, feel free to send the changes as pull requests here.

That branch is already a PR in #10.

@davidovitch
Copy link
Member

Appoligies....I totally missed that PR.

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Sep 20, 2015

No problem. I try to always open an issue and a corresponding PR to that issue. Some people prefer that way for better bookkeeping.

@davidovitch
Copy link
Member

I create a conda package here. It is easier than wheels.

Very nice indeed, thanks!

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Oct 25, 2015

Hi @davidovitch,

Just checking the reason for closing this. The developers have no interest in dropping the copied modules from scipy to a scipy import?

@davidovitch
Copy link
Member

ok, my bad, I was a bit quick, I thought this was related to PR #10 (which has been merged), but now I understand it isn't. Re-opening.

@davidovitch davidovitch reopened this Oct 25, 2015
@ocefpaf
Copy link
Contributor Author

ocefpaf commented Oct 25, 2015

No problem. Once things stabilize and the tests are running I will try to implement this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants