Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange L.DomEvent.skipped & L.DomEvent.fakeStop "is not a function" errors #55

Open
EricG-Personal opened this issue Jul 7, 2022 · 5 comments

Comments

@EricG-Personal
Copy link

I have a code pen at https://codepen.io/ericg97477/pen/eYMJrqj demonstrating the issue.

If I drag the square polygon, I get two errors in the console...

L.Path.Drag.js:6 Uncaught TypeError: L.DomEvent.fakeStop is not a function
    at i._onDragEnd (L.Path.Drag.js:6:3571)
    at HTMLDocument.o (DomEvent.js:108:13)
L.Path.Drag.js:6 Uncaught TypeError: L.DomEvent.skipped is not a function
    at i.<anonymous> (L.Path.Drag.js:6:3370)

I am not sure if this is a bug or something I am doing wrong.

I do note that at https://leafletjs.com/reference.html#domevent, it does not mention fakeStop or skipped methods.

Perhaps these were in older releases of leaflet...?

@EricG-Personal
Copy link
Author

I just saw that you did update the code which apparently handles this issue. When do you expect to release an update for leaflet 1.8?

@w8r
Copy link
Owner

w8r commented Jul 8, 2022

I cannot get the e2e tests working on gh actions, but I have no bandwidth to resolve it either. so I can release just as it is

@EricG-Personal
Copy link
Author

Cool. Thank you. If I experience any issues, I will let you know.

@EricG-Personal
Copy link
Author

On my codpen, I changed JS Setting for your package to https://unpkg.com/leaflet-path-drag, which should get me the latest version. I believe it is grabbing 1.8-beta.3

However, I am now getting an error...

leaflet-path-drag:1 Uncaught ReferenceError: require is not defined
    at leaflet-path-drag:1:1

@karolis-k
Copy link

karolis-k commented Jan 2, 2023

I updated to 1.8.0-beta.3, but I still get

ERROR TypeError: L.DomEvent.skipped is not a function
    at NewClass.<anonymous> (Path.Drag.js:213:20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants