-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant application: WasmEdge for Substrate #862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the application. This looks really interesting and definitely seems to be a project, which we want to support. Could you add the “default” deliverables 0a-0d of the template to each milestone? https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md And in general, feel free to add additional details to the deliverables (= requirements of the contract).
Signed-off-by: Michael Yuan <[email protected]> Update wasmedge_substrate.md Signed-off-by: Michael Yuan <[email protected]> Update wasmedge_substrate.md Signed-off-by: Michael Yuan <[email protected]>
Thanks! Fixed and added a little more details. I also squashed the new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I’m happy to support the project and I will share it with the rest of the team.
And just to clarify: We can obviously not ensure that this gets actually merged by parity, but it won’t be necessary for the approval of the milestone itself. |
Understood. We will make a best effort to be part of the standard substrate distro. :) Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Happy to see where this goes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juntao thanks for submitting this grant application. It sounds very interesting to me, I'm more than happy to approve. Looking forward to your delivery! 👍
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Signed-off-by: Michael Yuan <[email protected]> Update wasmedge_substrate.md Signed-off-by: Michael Yuan <[email protected]> Update wasmedge_substrate.md Signed-off-by: Michael Yuan <[email protected]>
Signed-off-by: Michael Yuan <[email protected]> Update wasmedge_substrate.md Signed-off-by: Michael Yuan <[email protected]> Update wasmedge_substrate.md Signed-off-by: Michael Yuan <[email protected]>
Hey @juntao, any updates on the third milestone? The performance benchmarks and analysis would probably be a big help in showcasing WasmEdge's potential for Substrate, are they still in your roadmap? |
Hi @juntao just bumping a friendly reminder, see Alxs comment above. |
Hi @alxs and @keeganquigley Thank you for following up. Happy new year. We have been preparing a PR to support WasmEdge as an alternative and configurable runtime for Substrate. However, it is coming along slowly since we need to bring our working branch of Substrate up to date first (we demoed on a Substrate version from a few months ago). There apparently have been a lot of changes. The performance WasmEdge is largely on par with wasmtime in Substrate -- WasmEdge is faster in some cases, but slower in others. We can continue to tweak the performance over time. Besides that, I think there are compelling reasons to support WasmEdge in Substrate. Specifically,
In any case, my apologies for the delay. But we are still working on the compatibility issues to bring it up to date with the latest and greatest Substrate! Stay tuned. cheers |
@juntao Thanks a lot for the update. If you need longer to finish this grant, please update the original application via a PR as well as the estimated duration. This way, your contract is officially updated, and you could integrate additional changes/work, etc. |
Hi @juntao any updates you can provide? Please note that if we don't hear from you after a few weeks, the grant could be subject to termination due to inactivity. |
As discussed here: w3f#862 (comment) the milestone w3f#3 task is much greater than we originally envisioned. We need to reconcile changes to the substrate code base since we started and then merge our changes back into the main tree in order to propose an upstream PR and run the most up-to-date performance tests. So, I extended the time needed for this task to 6 months. Thank you.
As discussed here: #862 (comment) the milestone #3 task is much greater than we originally envisioned. We need to reconcile changes to the substrate code base since we started and then merge our changes back into the main tree in order to propose an upstream PR and run the most up-to-date performance tests. So, I extended the time needed for this task to 6 months. Thank you.
Hi @juntao are you able to provide an update? |
Hi @juntao unless you are planning to deliver soon, I think it's best to close this grant for now and it can always potentially be re-opened in the future should you wish to continue working on it. Please let me know otherwise I'll go ahead and file the PR to be reviewed by the committee. |
Yes, I think it is perhaps best to close it for now. The substrate main code branch has advanced over time, and it becomes harder and harder to merge over time. We now know that it is viable to swap out wasmtime for WasmEdge in substrate. When there is concrete demand for this from the community, we can revisit this again. Thank you. |
Thanks for the update @juntao much obliged. I will go ahead and file it now. |
Project Abstract
Supporting WasmEdge as an alternative Substrate WebAssembly runtime. The project increases the Substrate ecosystem's node software diversity by supporting an alternative high-performance WebAssembly Runtime implementation. The project team are the maintainers of the WasmEdge WebAssembly Runtime project, and had successfully completed W3F projects in the past.
For which grant level are you applying?
Application Checklist
project_name.md
) and updated.