-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tellor grant application #1532
Tellor grant application #1532
Conversation
* added Tellor's application * chore: clarify proposal * updated reporter repo * updated tellor.md --------- Co-authored-by: Frank Bell <[email protected]>
Thanks for the interesting application @brendaloya. As far as I'm aware, neither the Chainlink oracle pallet nor the Chainlink price feed pallet are maintained anymore, which makes your application intriguing. Couple of questions/comments:
|
* added Tellor's application * chore: clarify proposal * updated reporter repo * updated tellor.md * updated milestones --------- Co-authored-by: Frank Bell <[email protected]>
Thanks for the feedback @keeganquigley. I've added comments below and made some updates (changed the application to two milestones).
-Response: Once implemented our proposed solution could function with zero team interaction because anyone can become a reporter as long as they stake, reporters are incentivized by consumers to provide data through payments, the data validation is open to anyone that pays the fee to dispute and everyone is incentivized to dispute because you get the reporter stake if the dispute is successful otherwise the reporter is compensated with the fee for reward/consumer payment losses. I can't speak for another project but truly decentralized and crypto-economically incentivized systems do not stop working because the team does not maintain them. However, we do plan to help with the reporter bootstrapping and future projects' integrations as demand and usage of Parity/Polkadot ecosystem increases.
-Response: Some of the EVM contracts exist, however, some have to be developed and there will be some updates to ensure these work with the Parity/Polkadot ecosystem and tested.
-Response: I changed these to be two milestones now.
-Response: If this is approved we will do a follow-up grant for mainnet. Tellor has been live since August 2019, all of our code is open source https://github.com/tellor-io/ and happy to walk the committee through any of our work.
-Response: We'll look into it but at first glance I can't easily find how becoming a data transmitter is open to anyone or if the process of becoming one is decentralized. They also don't seem to have any penalties for these providing bad data or a live dispute process. Our system is crypto-economically secured and has a dispute process in place.
-Response: Will do. However, we don't plan to launch a new token and TRB is currently available at Coinbase and Binance. Our proposed solution would rely on bridged TRB or the consumer chain's token.
-Response: Yes, since August 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes @brendaloya I have marked your application as ready for review and will share it with the rest of the committee.
Seeing as this is an interesting XCM use case, and we need more work done on oracles, I'm personally happy to support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your application. It is a very interesting one. I notice that in milestone 1, deliverable 3, there is no specification in this item. Could you please add it? Please notice that we usually perform system tests on deliverables as part of the Milestone evaluation process which requires a tutorial for manual testing or automated e2e tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the application. I have a couple of questions/comments:
- Currently, the headline for milestone 2 is missing. Could you please add this?
- Your first milestone focuses on solidity smart contracts. We usually prefer to support the development of ink! Smart contracts or other solutions that are native to our ecosystem. Would you be willing to integrate this (at least initial PoCs) into the application? I saw that you mentioned that you plan on working on WASM smart contracts.
- Could you remove the Tellor Tributes (TRB) Token from the application? See our guidelines: https://github.com/w3f/Grants-Program#guidelines
- Could you also add a reference to the definition that is listed above in the document for the integration contract ("with the functionality described above")? In general, feel free to add more details to the milestone tables also for the pallet since these are the requirements of our contracts.
- Finally, do you have plans to integrate off-chain works into your oracle solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applications/Tellor.md
Outdated
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. | | ||
| 1 | Develop Controller contracts | We will provide a set of solidity smart contracts with the functionality described above | | ||
| 2 | Develop Parachain integration contract| We will provide an integration contract | | ||
| 3 | Local testing| | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @dsm-w3f said, this still requires a specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct deliverable 0c should cover the testing so I’ve removed deliverable 3 from milestone 1.
applications/Tellor.md
Outdated
| **0c.** | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. | | ||
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. | | ||
| 1 | Substrate Oracle pallet design and integration | We will provide the Substrate oracle pallet | | ||
| 2 | Testing the pallet and testing integration with projects and selected parachains| We will test full functionality of the system for interactions between the consumer chain and oracle pallet | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is being delivered here? A test report? There is already a Testing and Testing Guide
deliverable above, how is this different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @semuelle , Milestone 2 deliverable 2 could be part of deliverable *0c but I just wanted to spell out that we have to test milestone 1 and 2 interoperability, happy to remove it though.
pinging @brendaloya |
…tin deliverable on milestone 1 deliverable 3, expanded on milestone 2 delivarable 2
Response: |
Hi @Noc2 ,
-Response: Done
-Response: We would love to explore it but I currently don’t have anyone in the team that is fluent in ink! and the proposal right now tries to minimize costs. Currently we plan on creating contracts enable interaction with the XCM and making changes to fit Parity’s parachains ecosystem. Rewriting the existing contracts on a different language and getting an audit on that language would make this iteration very expensive. We would love to see some usage and if users begin demanding the change to ink! for integrations, we would be happy to explore it.
-Response: Done
-Response: Added the reference and some clarification but let me know if more details are needed. We will have a full spec.
-Response: not currently but happy to explore and brainstorm if it would be a good fit. |
applications/Tellor.md
Outdated
| **0c.** | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. | | ||
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. | | ||
| 1 | Substrate Oracle pallet design and integration | We will provide the Substrate oracle pallet | | ||
| 2 | Testing functionallity of the the pallet and testing integration with a mock project and selected parachains| We will test full functionality of the system for interactions between the consumer chain and oracle pallet (meaning test the functinallity between milestone 1 and 2 - solidity contracts, pallet, XCM)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify what is being delivered here. A testing guide? Test report? Article?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @semuelle , thanks for the feedback.
Please specify what is being delivered here. A testing guide? Test report? Article?
-Response: On deliverable 2, what is being delivered is just more testing. I read deliverable 0c as being more specific to the pallet testing (deliverable 1) so in deliverable 2 it would just be more tests delivered/included that test the interoperability between milestone 1 and milestone 2 deliverable 1. I could remove it if you think that is covered by deliverable 0c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's fine given the architecture. It just needs to be clear from the specification of the deliverable what exactly will be delivered, so that we know what to expect. You could add, for example, "we will provide a tutorial how to replicate these tests locally."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @semuelle , I've added clarification on milestone 2 deliverable 1 since we'll definitely provide a guide on running the additional tests.
Just for transparency: I have updated your comment above for readability. Github was interpreting everything as one large quote. |
Thanks @semuelle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds interesting, especially since the Chainlink Substrate oracle pallet hasn't been updated in a while and doesn't seem to be actively maintained anymore. Happy to approve.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Hi @brendaloya how is milestone 2 coming along? |
pinging @brendaloya |
Hi @brendaloya are you still working on this grant? Please note that if we don't hear back from you after two weeks we will file a PR to close the grant due to inactivity. Thank you for understanding. |
added Tellor's application
chore: clarify proposal
updated reporter repo
updated tellor.md
Co-authored-by: Frank Bell [email protected]
Project Abstract
Oracles are a key piece of infrastructure for any blockchain ecosystem. Tellor proposes a crypto economically incentivized oracle that is completely flexible for the needs of any data type or frequency. For this Tellor will implement an oracle pallet along with a deployment of controller smart contracts on a to-be-selected EVM parachain that will handle the reporter staking staking, governance (for disputing data validity), and reporter reward system. This will enable parachains across the ecosystem to read, and/or request a push of oracle data. Once the network of reporters is bootstrapped, there is minimal team intervention needed. Anyone can become a reporter by staking, anyone can dispute the validity of the data for a fee, and the user can incentivize reporters to quickly add or replace the data they need by posting a reward. The system is permissionless, as well as sybil and censorship resistant.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)