From f3f8bdcb6306678a699973b3750e96872f4eb385 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Wed, 6 Oct 2021 16:19:18 +0200 Subject: [PATCH] More tests links --- deliveries/polkadot-desktop-app-milestone-3.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index bc98db253..0e289a6f8 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -8,8 +8,8 @@ | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | -| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
Automated tests - primarily in [App Accounts][code-accounts-tests] - consult PRs for details. |
  1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
  2. [Tag styles][pr-tag-styles]
  3. [Account collapsible details row][pr-row-details]
  4. [Style address balances][pr-style-address-balances]
  5. [Add accounts sorting][pr-accounts-sorting]
  6. [Replace SUI popup with custom one][pr-replace-sui-popup]
  7. [Display parent above account name][pr-display-parent]
  8. [Account actions popup redesign][pr-accounts-popup]
  9. [Explorer links placement][pr-accounts-buttons]
  10. [Add hover to expand button][pr-expand-hover]
  11. [Account filter placement][pr-move-filter-input]
  12. [Style sort input][pr-sort-style]
  13. [Apply table style to Address Book][pr-row-details-addresses]
  14. [Apply button and filter styles to Address Book][pr-filter-addresses]
  15. [Correct row coloring when filtering][pr-filtering-bugfix]
  16. [Style account badges][pr-badges]
  17. [Style table headers][pr-table-headers]
  18. [Style redeemable balances in expanded view][pr-redeemable]
      19. | -| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
      Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details. |
      1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
      2. [Accounts flags placement][pr-flags-width]
      3. [Icons for explorer links][pr-sidebar-links]
      4. [Style flags][pr-sidebar-flags]
      5. [Edit name and tags][pr-sidebar-edit]
      6. [Style identity and balances sections][pr-sidebar-identity]
      7. [Increase width][pr-sidebar-width]
      8. [Style upper part][pr-sidebar-style-upper]
      | +| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
      Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
      Automated tests - primarily in [App Accounts][code-accounts-tests], applied also to Address Book - consult PRs for details. |
      1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
      2. [Tag styles][pr-tag-styles]
      3. [Account collapsible details row][pr-row-details]
      4. [Style address balances][pr-style-address-balances]
      5. [Add accounts sorting][pr-accounts-sorting]
      6. [Replace SUI popup with custom one][pr-replace-sui-popup]
      7. [Display parent above account name][pr-display-parent]
      8. [Account actions popup redesign][pr-accounts-popup]
      9. [Explorer links placement][pr-accounts-buttons]
      10. [Add hover to expand button][pr-expand-hover]
      11. [Account filter placement][pr-move-filter-input]
      12. [Style sort input][pr-sort-style]
      13. [Apply table style to Address Book][pr-row-details-addresses]
      14. [Apply button and filter styles to Address Book][pr-filter-addresses]
      15. [Correct row coloring when filtering][pr-filtering-bugfix]
      16. [Style account badges][pr-badges]
      17. [Style table headers][pr-table-headers]
      18. [Style redeemable balances in expanded view][pr-redeemable]
          19. | +| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
          Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details.
          Automated tests in [Sidebar.spec][code-sidebar-tests] |
          1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
          2. [Accounts flags placement][pr-flags-width]
          3. [Icons for explorer links][pr-sidebar-links]
          4. [Style flags][pr-sidebar-flags]
          5. [Edit name and tags][pr-sidebar-edit]
          6. [Style identity and balances sections][pr-sidebar-identity]
          7. [Increase width][pr-sidebar-width]
          8. [Style upper part][pr-sidebar-style-upper]
          | | 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
          1. [Create/derive - remove code duplication][pr-modals-duplication]
          2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
          3. [Support keyboard in modals][pr-keyboard-in-modal]
          | | 5. | Documentation updates | TODO | | @@ -21,6 +21,7 @@ Most of the PRs listed include automated tests. [figma-designs]: https://www.figma.com/file/5NAICV06SHNbbIoYhrUS3u/PolkaDot?node-id=2839%3A8075 [code-accounts]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.tsx [code-accounts-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.spec.ts +[code-sidebar-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Sidebar/Sidebar.spec.tsx [pr-summary-bar]: https://github.com/polkadot-js/apps/pull/5876 [pr-summary-bar-styles]: https://github.com/polkadot-js/apps/pull/5891 [pr-tag-styles]: https://github.com/polkadot-js/apps/pull/5893