diff --git a/evaluations/ink-analyzer-phase-2_4_keeganquigley.md b/evaluations/ink-analyzer-phase-2_4_keeganquigley.md index 440da9bb1..203e542c9 100644 --- a/evaluations/ink-analyzer-phase-2_4_keeganquigley.md +++ b/evaluations/ink-analyzer-phase-2_4_keeganquigley.md @@ -7,15 +7,15 @@ **Deliverables** -| Number | Deliverable | Link | Notes | -|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| **0a.** | License | [MIT](https://github.com/ink-analyzer/ink-analyzer/blob/master/LICENSE-MIT) or [Apache 2.0](https://github.com/ink-analyzer/ink-analyzer/blob/master/LICENSE-APACHE). | Dual-licensed under either of MIT or Apache 2.0 licenses at the downstream user's option. | -| **0b.** | Documentation | [Project README](https://github.com/ink-analyzer/ink-analyzer#readme) and [semantic analyzer (ink-analyzer) crate README](https://github.com/ink-analyzer/ink-analyzer/tree/master/crates/analyzer#readme) on GitHub, [semantic analyzer crate (ink-analyzer) rustdoc](https://docs.rs/ink-analyzer/latest/ink_analyzer/) documentation on docs.rs and extensive inline source documentation. | | -| **0c.** | Testing and Testing Guide | [Testing guide](https://github.com/ink-analyzer/ink-analyzer#testing). | | -| **0d.** | Docker | [Dockerfile](https://github.com/ink-analyzer/ink-analyzer/blob/master/Dockerfile). | | -| 1. | Semantic Analyzer: Rust crate update: Diagnostics that verify that the chain extension `ErrorCode` type is `impl FromStatusCode` as well as quick fixes and code/intent actions to `impl FromStatusCode` for the target item where necessary | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_impl_from_status_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs#L88-L106) utility in the [diagnostics/chain_extension/error_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs) submodule. | | -| 2. | Semantic Analyzer: Rust crate update: Diagnostics for references to the chain extension's `ErrorCode` type using `Self::ErrorCode` in the chain extension and it's defined methods as well as quick fixes to replace `Self::ErrorCode` usages with the `ErrorCode` type directly | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_no_self_error_code_usage](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs#L119-L152) utility in the [diagnostics/chain_extension/error_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs) submodule. | | -| 3. | Semantic Analyzer: Rust crate update: Diagnostics that verify that the chain extension `ErrorCode` type implements SCALE codec traits (i.e. scale's `Encode` and `Decode` and scale-info's `TypeInfo`) as well as quick fixes and code/intent actions to implement the SCALE codec traits for the target item where necessary | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_impl_scale_codec_traits](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs#L108-L117) utility in the [diagnostics/chain_extension/error_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs) submodule. | | -| 4. | Semantic Analyzer: Rust crate update: Diagnostics that verify that input and output types of chain extension methods implement SCALE codec traits (i.e. scale's `Encode` and `Decode` and scale-info's `TypeInfo`) as well as quick fixes and code/intent actions to implement the SCALE codec traits for the target item where necessary | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_custom_types_impl_scale_codec_traits](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/extension.rs#L50-L106) utility in the [diagnostics/extension](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/extension.rs) submodule. | +| Number | Deliverable | Accepted | Link | Notes | +|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| ------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| **0a.** | License | | [MIT](https://github.com/ink-analyzer/ink-analyzer/blob/master/LICENSE-MIT) or [Apache 2.0](https://github.com/ink-analyzer/ink-analyzer/blob/master/LICENSE-APACHE). | Dual-licensed under either of MIT or Apache 2.0 licenses at the downstream user's option. | +| **0b.** | Documentation | |[Project README](https://github.com/ink-analyzer/ink-analyzer#readme) and [semantic analyzer (ink-analyzer) crate README](https://github.com/ink-analyzer/ink-analyzer/tree/master/crates/analyzer#readme) on GitHub, [semantic analyzer crate (ink-analyzer) rustdoc](https://docs.rs/ink-analyzer/latest/ink_analyzer/) documentation on docs.rs and extensive inline source documentation. | | +| **0c.** | Testing and Testing Guide | | [Testing guide](https://github.com/ink-analyzer/ink-analyzer#testing). | | +| **0d.** | Docker | | [Dockerfile](https://github.com/ink-analyzer/ink-analyzer/blob/master/Dockerfile). | | +| 1. | Semantic Analyzer: Rust crate update: Diagnostics that verify that the chain extension `ErrorCode` type is `impl FromStatusCode` as well as quick fixes and code/intent actions to `impl FromStatusCode` for the target item where necessary | | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_impl_from_status_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs#L88-L106) utility in the [diagnostics/chain_extension/error_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs) submodule. | | +| 2. | Semantic Analyzer: Rust crate update: Diagnostics for references to the chain extension's `ErrorCode` type using `Self::ErrorCode` in the chain extension and it's defined methods as well as quick fixes to replace `Self::ErrorCode` usages with the `ErrorCode` type directly | | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_no_self_error_code_usage](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs#L119-L152) utility in the [diagnostics/chain_extension/error_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs) submodule. | | +| 3. | Semantic Analyzer: Rust crate update: Diagnostics that verify that the chain extension `ErrorCode` type implements SCALE codec traits (i.e. scale's `Encode` and `Decode` and scale-info's `TypeInfo`) as well as quick fixes and code/intent actions to implement the SCALE codec traits for the target item where necessary | | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_impl_scale_codec_traits](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs#L108-L117) utility in the [diagnostics/chain_extension/error_code](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/chain_extension/error_code.rs) submodule. | | +| 4. | Semantic Analyzer: Rust crate update: Diagnostics that verify that input and output types of chain extension methods implement SCALE codec traits (i.e. scale's `Encode` and `Decode` and scale-info's `TypeInfo`) as well as quick fixes and code/intent actions to implement the SCALE codec traits for the target item where necessary | | [GitHub repository](https://github.com/ink-analyzer/ink-analyzer) and the [ensure_custom_types_impl_scale_codec_traits](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/extension.rs#L50-L106) utility in the [diagnostics/extension](https://github.com/ink-analyzer/ink-analyzer/blob/analyzer-v0.8.17/crates/analyzer/src/analysis/diagnostics/extension.rs) submodule. | ## General Notes