From d16dc56921750ec773337f0a20c0ff76ec86e741 Mon Sep 17 00:00:00 2001 From: Piet <75956460+PieWol@users.noreply.github.com> Date: Thu, 13 Jun 2024 15:29:16 +0200 Subject: [PATCH] Ink playground m2 (#1189) * accept ink-playground m2 * fix deliverable links --- evaluations/ink_playground_2_PieWol.md | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 evaluations/ink_playground_2_PieWol.md diff --git a/evaluations/ink_playground_2_PieWol.md b/evaluations/ink_playground_2_PieWol.md new file mode 100644 index 000000000..601fa99af --- /dev/null +++ b/evaluations/ink_playground_2_PieWol.md @@ -0,0 +1,26 @@ +# Evaluation + + +- **Status:** accepted +- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/ink-playground-ide-improvements.md +- **Milestone:** 2 +- **Previously successfully merged evaluation:** all by PieWol + +**Milestone Number:** 2 + +**Context** +Implement playground features for ink crate docs. + +**Deliverables** + +| Number | Deliverable | Accepted | Link | Evaluation Notes | +| ------------- | ------------- | ------------- |------------- | ------------- | +| 0.a. | License | | https://github.com/Zeeve-App/ink-playground/blob/version_play/LICENSE | Apache-2.0 | +| 0.b. | Documentation | |https://github.com/Zeeve-App/ink-playground/blob/version_play/README.md | | +| 1. | Ink! crate docs | | [use-ink/ink-playground#817](https://github.com/use-ink/ink-playground/pull/817), https://github.com/paritytech/ink-playground/blob/f2f44735310b4f966ade842125bc56eaaf915c95/packages/playground/src/app/index.tsx, https://github.com/Zeeve-App/ink-playground/commit/5bb6b61e067ea1b9ce17d099d994993e891437c1, https://github.com/Zeeve-App/ink/commit/0a4f21e89e2515db37b664632d7e3d0c4d1ec54f| only for one example but correctly implemented. | + + +## General Notes +Thanks for the implementation. I would love to see these changes making their way into the official ink repo once it will be picked up by new ecosystem players. + +I couldn't test for various reasons but given the circumstances I will accept this delivery.