diff --git a/evaluations/polkamask_1_keeganquigley.md b/evaluations/polkamask_1_keeganquigley.md index 435f362da..291e5e6fa 100644 --- a/evaluations/polkamask_1_keeganquigley.md +++ b/evaluations/polkamask_1_keeganquigley.md @@ -1,6 +1,6 @@ # Evaluation -- **Status:** In progress +- **Status:** Accepted - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/polkamask.md - **Milestone:** 1 - **Previously successfully merged evaluation:** All by keeganquigley @@ -10,16 +10,28 @@ | Number | Deliverable | Accepted | Link | Notes | | ------ | ------------- | ------------- | ------------- | ------------- | | 0a. | License Apache 2.0 | | https://github.com/PolkaGate/polkaMask/blob/main/LICENSE.APACHE2 | -| 0b. | Documentation | | https://github.com/PolkaGate/polkaMask/wiki | | -| 0c. | Testing and Testing Guide | | https://github.com/PolkaGate/polkaMask#running-the-repository | | -| 0d. | Docker | | https://github.com/PolkaGate/polkaMask?tab=readme-ov-file#docker | | -| 0e. | Article | | https://medium.com/@polkagate/polkamask-polkadot-with-metamask-0d0e5e12f2d6 | -| 1. | Polkagate Signer (Metamask Snap) | | https://github.com/PolkaGate/polkaMask/tree/main/packages/snap | | -| 2. | Upgraded Polkadot extension-dapp | | https://github.com/PolkaGate/polkadot-js-extension/tree/master/packages/extension-dapp/src/snap | | -| 3. | Upgraded Polkadot-Cloud | | https://github.com/PolkaGate/polkadot-cloud-library/commit/a29606260ef6ef79137b745d2c5c1336346bcb02 | | +| 0b. | Documentation | | https://github.com/PolkaGate/polkaMask/wiki | Good docs. | +| 0c. | Testing and Testing Guide | | https://github.com/PolkaGate/polkaMask#running-the-repository | Looks good. | +| 0d. | Docker | | https://github.com/PolkaGate/polkaMask?tab=readme-ov-file#docker | Looks good. | +| 0e. | Article | | https://medium.com/@polkagate/polkamask-polkadot-with-metamask-0d0e5e12f2d6 | Looks good. +| 1. | Polkagate Signer (Metamask Snap) | | https://github.com/PolkaGate/polkaMask/tree/main/packages/snap | Looks good. | +| 2. | Upgraded Polkadot extension-dapp | | https://github.com/PolkaGate/polkadot-js-extension/tree/master/packages/extension-dapp/src/snap | Looks good. | +| 3. | Upgraded Polkadot-Cloud | | https://github.com/PolkaGate/polkadot-cloud-library/commit/a29606260ef6ef79137b745d2c5c1336346bcb02 | Looks good. | # General Notes +Awesome work! It's very nice to be able to use all the common extrinsics in MetaMask! I was able to update the extension metadata, transfer WND, bond and nominate, and fully unbond. Everything worked great out of the box, although I did have to disable other extensions so they weren't fighting with MetaMask for control. + +Works both locally and on the test chain. Nice work in utilizing the work of Chainsafe and Polkadot Cloud. + +metadata + +metamask + +bonding + +bonding 2 + ## Tests Unit tests passing: