From 7101f45f48c7e771aa624517e75f7967196d634f Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Sat, 9 Mar 2024 00:28:09 +0100 Subject: [PATCH 1/5] init --- evaluations/create-substrate-app-1-piewol | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 evaluations/create-substrate-app-1-piewol diff --git a/evaluations/create-substrate-app-1-piewol b/evaluations/create-substrate-app-1-piewol new file mode 100644 index 000000000..d913f2105 --- /dev/null +++ b/evaluations/create-substrate-app-1-piewol @@ -0,0 +1,75 @@ +# Evaluation + + +- **Status:** in progress +- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/create-substrate-app.md +- **Milestone:** 1 +- **Previously successfully merged evaluation:** All evaluations by PieWol + + +**Milestone 2** + +| Number | Deliverable | Accepted |Link | Evaluation Notes | +|--------:|---------------------------------------| :------: |-----------------------------------------------------------------------------------------------------------------------------------------------------------------|------------| +| **0a.** | License | |https://www.apache.org/licenses/LICENSE-2.0| Please include the Apache 2.0 License in your own repo aswell | +| **0b.** | Documentation | |https://www.create-substrate-app.dev/| nice layout and concise docs | +| **0c.** | Testing and Testing Guide | |https://www.create-substrate-app.dev/docs/available-scripts | listed test [commands](https://www.create-substrate-app.dev/docs/available-scripts) don't work for every template. I think one needs to be ``npm test:unit`` | +| 0e. | Article | |https://www.philoniare.com/blog/create-substrate-app| good summary. | +| 1. | TypeScript React Front-End Template | |https://github.com/philoniare/create-substrate-app/tree/master/packages/react| tests don't pass | +| 2. | TypeScript Vue Front-End Template | |https://github.com/philoniare/create-substrate-app/tree/master/packages/vue| readme has issues | +| 3. | TypeScript Angular Front-End Template | |https://github.com/philoniare/create-substrate-app/tree/master/packages/angular| tests still don't pass. as tests are minimal should be an easy fix. | +| 4. | Published Global CLI command | |https://www.npmjs.com/package/create-substrate-app| very nice, could you add the license here too? | + + + +## General Notes +Can you please also include a feature to select accounts in case the user connects with multiple accounts to the website? + +Also depending on the network chosen the account representation should change. Right now it seems to always display the polkadot representation. + +Overall only minor change requests. Thank you! + +## vue readme +[readme](https://github.com/philoniare/create-substrate-app/tree/master/packages/vue#compile-and-hot-reload-for-development) says there is the command ``npm run dev`` but it doesn't actually exist. + +## angular template +template fails ``npm run test`` + +also the "connect wallet" button seems to not work correctly. Please give it a check. Seems like once connected accounts in the wallet are changed the website is not updating. + +## react template +In the react-template readme you try to link to the create-substrate-app repo but you link to the actual create-react-app repo. + + +react app fails ``npm run test`` +
+ + create-substrate-app/re-app/node_modules/@polkadot/rpc-core/types/jsonrpc.js:1 + ({"Object.":function(module,exports,require,__dirname,__filename,jest){export {}; + ^^^^^^ + + SyntaxError: Unexpected token 'export' + + 7 | useState, + 8 | } from "react"; + > 9 | import { ApiPromise, WsProvider } from "@polkadot/api"; + | ^ + 10 | import { + 11 | web3AccountsSubscribe, + 12 | web3Enable, + + at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1728:14) + at Object. (node_modules/@polkadot/rpc-augment/cjs/augment/jsonrpc.js:4:1) + at Object. (node_modules/@polkadot/rpc-augment/cjs/augment/index.js:3:1) + at Object. (node_modules/@polkadot/rpc-augment/cjs/bundle.js:4:1) + at Object. (node_modules/@polkadot/rpc-augment/cjs/index.js:5:22) + at Object. (node_modules/@polkadot/api/cjs/bundle.js:5:1) + at Object. (node_modules/@polkadot/api/cjs/index.js:5:22) + at Object. (src/substrate/SubstrateContext.tsx:9:1) + at Object. (src/App.tsx:2:1) + at Object. (src/App.test.tsx:3:1) + + Test Suites: 1 failed, 1 total + +
+ From a9b929113a078f06029d868a93012fbbdcd59322 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Sat, 9 Mar 2024 00:28:28 +0100 Subject: [PATCH 2/5] m1 --- evaluations/create-substrate-app-1-piewol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evaluations/create-substrate-app-1-piewol b/evaluations/create-substrate-app-1-piewol index d913f2105..bb212da87 100644 --- a/evaluations/create-substrate-app-1-piewol +++ b/evaluations/create-substrate-app-1-piewol @@ -7,7 +7,7 @@ - **Previously successfully merged evaluation:** All evaluations by PieWol -**Milestone 2** +**Milestone 1** | Number | Deliverable | Accepted |Link | Evaluation Notes | |--------:|---------------------------------------| :------: |-----------------------------------------------------------------------------------------------------------------------------------------------------------------|------------| From 42763090f889213d493cc2bce0d14fc96de9f217 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Sat, 9 Mar 2024 00:33:16 +0100 Subject: [PATCH 3/5] fix file --- ...te-substrate-app-1-piewol => create-substrate-app-1-piewol.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename evaluations/{create-substrate-app-1-piewol => create-substrate-app-1-piewol.md} (100%) diff --git a/evaluations/create-substrate-app-1-piewol b/evaluations/create-substrate-app-1-piewol.md similarity index 100% rename from evaluations/create-substrate-app-1-piewol rename to evaluations/create-substrate-app-1-piewol.md From aff52b0135c4da30af9dd91f93ecff34c01b9794 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Tue, 12 Mar 2024 21:19:30 +0100 Subject: [PATCH 4/5] update eval --- evaluations/create-substrate-app-1-piewol.md | 63 +++----------------- 1 file changed, 9 insertions(+), 54 deletions(-) diff --git a/evaluations/create-substrate-app-1-piewol.md b/evaluations/create-substrate-app-1-piewol.md index bb212da87..d6601e955 100644 --- a/evaluations/create-substrate-app-1-piewol.md +++ b/evaluations/create-substrate-app-1-piewol.md @@ -11,65 +11,20 @@ | Number | Deliverable | Accepted |Link | Evaluation Notes | |--------:|---------------------------------------| :------: |-----------------------------------------------------------------------------------------------------------------------------------------------------------------|------------| -| **0a.** | License |
  • []
|https://www.apache.org/licenses/LICENSE-2.0| Please include the Apache 2.0 License in your own repo aswell | +| **0a.** | License |
  • [x]
|https://www.apache.org/licenses/LICENSE-2.0| | | **0b.** | Documentation |
  • [x]
|https://www.create-substrate-app.dev/| nice layout and concise docs | -| **0c.** | Testing and Testing Guide |
  • []
|https://www.create-substrate-app.dev/docs/available-scripts | listed test [commands](https://www.create-substrate-app.dev/docs/available-scripts) don't work for every template. I think one needs to be ``npm test:unit`` | -| 0e. | Article |
  • [x]
|https://www.philoniare.com/blog/create-substrate-app| good summary. | -| 1. | TypeScript React Front-End Template |
  • []
|https://github.com/philoniare/create-substrate-app/tree/master/packages/react| tests don't pass | -| 2. | TypeScript Vue Front-End Template |
  • []
|https://github.com/philoniare/create-substrate-app/tree/master/packages/vue| readme has issues | -| 3. | TypeScript Angular Front-End Template |
  • []
|https://github.com/philoniare/create-substrate-app/tree/master/packages/angular| tests still don't pass. as tests are minimal should be an easy fix. | -| 4. | Published Global CLI command |
  • [x]
|https://www.npmjs.com/package/create-substrate-app| very nice, could you add the license here too? | +| **0c.** | Testing and Testing Guide |
  • [x]
|https://www.create-substrate-app.dev/docs/available-scripts | works | +| 0e. | Article |
  • [x]
|https://www.philoniare.com/blog/create-substrate-app| good | +| 1. | TypeScript React Front-End Template |
  • [x]
|https://github.com/philoniare/create-substrate-app/tree/master/packages/react| works | +| 2. | TypeScript Vue Front-End Template |
  • [x]
|https://github.com/philoniare/create-substrate-app/tree/master/packages/vue| works| +| 3. | TypeScript Angular Front-End Template |
  • [x]
|https://github.com/philoniare/create-substrate-app/tree/master/packages/angular| works | +| 4. | Published Global CLI command |
  • [x]
|https://www.npmjs.com/package/create-substrate-app| good | ## General Notes -Can you please also include a feature to select accounts in case the user connects with multiple accounts to the website? +Thank you for the quick changes, the milestone looks good to me now. All tests are passing. I see this as accepted. -Also depending on the network chosen the account representation should change. Right now it seems to always display the polkadot representation. +I appreciate that all suggestion were quickly picked up and delivered. -Overall only minor change requests. Thank you! - -## vue readme -[readme](https://github.com/philoniare/create-substrate-app/tree/master/packages/vue#compile-and-hot-reload-for-development) says there is the command ``npm run dev`` but it doesn't actually exist. - -## angular template -template fails ``npm run test`` - -also the "connect wallet" button seems to not work correctly. Please give it a check. Seems like once connected accounts in the wallet are changed the website is not updating. - -## react template -In the react-template readme you try to link to the create-substrate-app repo but you link to the actual create-react-app repo. - - -react app fails ``npm run test`` -
- - create-substrate-app/re-app/node_modules/@polkadot/rpc-core/types/jsonrpc.js:1 - ({"Object.":function(module,exports,require,__dirname,__filename,jest){export {}; - ^^^^^^ - - SyntaxError: Unexpected token 'export' - - 7 | useState, - 8 | } from "react"; - > 9 | import { ApiPromise, WsProvider } from "@polkadot/api"; - | ^ - 10 | import { - 11 | web3AccountsSubscribe, - 12 | web3Enable, - - at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1728:14) - at Object. (node_modules/@polkadot/rpc-augment/cjs/augment/jsonrpc.js:4:1) - at Object. (node_modules/@polkadot/rpc-augment/cjs/augment/index.js:3:1) - at Object. (node_modules/@polkadot/rpc-augment/cjs/bundle.js:4:1) - at Object. (node_modules/@polkadot/rpc-augment/cjs/index.js:5:22) - at Object. (node_modules/@polkadot/api/cjs/bundle.js:5:1) - at Object. (node_modules/@polkadot/api/cjs/index.js:5:22) - at Object. (src/substrate/SubstrateContext.tsx:9:1) - at Object. (src/App.tsx:2:1) - at Object. (src/App.test.tsx:3:1) - - Test Suites: 1 failed, 1 total - -
From d59155db28634e602b2edb2beaca122d15a38351 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Wed, 13 Mar 2024 17:53:02 +0100 Subject: [PATCH 5/5] accepted --- evaluations/create-substrate-app-1-piewol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evaluations/create-substrate-app-1-piewol.md b/evaluations/create-substrate-app-1-piewol.md index d6601e955..18ce1cd99 100644 --- a/evaluations/create-substrate-app-1-piewol.md +++ b/evaluations/create-substrate-app-1-piewol.md @@ -1,7 +1,7 @@ # Evaluation -- **Status:** in progress +- **Status:** accepted - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/create-substrate-app.md - **Milestone:** 1 - **Previously successfully merged evaluation:** All evaluations by PieWol