From 338f153629feb9fda62c5c7e07c33ac40fa7d3dd Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Fri, 20 Aug 2021 19:00:44 +0200 Subject: [PATCH 1/8] Create polkadot-desktop-app-milestone-3.md --- .../polkadot-desktop-app-milestone-3.md | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 deliveries/polkadot-desktop-app-milestone-3.md diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md new file mode 100644 index 000000000..c92c09b17 --- /dev/null +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -0,0 +1,21 @@ +# Milestone Delivery :mailbox: + +**The [invoice form :pencil:](https://docs.google.com/forms/d/e/1FAIpQLSfmNYaoCgrxyhzgoKQ0ynQvnNRoTmgApz9NrMp-hd8mhIiO0A/viewform) has been filled out correctly for this milestone and the delivery is according to the official [milestone delivery guidelines](https://github.com/w3f/Grants-Program/blob/master/docs/milestone-deliverables-guidelines.md).** + +* **Application Document:** [link](https://github.com/w3f/Grants-Program/blob/master/applications/polkadot-desktop-app.md) +* **Milestone Number:** 3 + +| Number | Deliverable | Link | Notes | +| --- | -------------------------------- | ------------- |------ | +| 1. | Accounts list redesign | [Figma designs](figma-designs) | TODO: Dev Handoff. After dev, we need to clean up for the sake of this Delivery | +| 2. | Accounts list implementation |
  1. [Summary bar][pr-summary-bar] (+ [styles][pr-summary-bar-styles])
  2. [Tag styles](pr-tag-styles)
  3. [Account collapsible details row][pr-row-details]
      4. | development in progress | +| 3. | Accounts sidebar implementation | TODO | Figma designs: work-in-progress | +| 4. | Accounts App modals improvements |
      1. [Create/derive - remove code duplication][pr-modals-duplication]
      | development in progress | +| 5. | Documentation updates | TODO | | + +[figma-designs]: https://www.figma.com/file/5NAICV06SHNbbIoYhrUS3u/PolkaDot?node-id=2839%3A8075 +[pr-summary-bar]: https://github.com/polkadot-js/apps/pull/5876 +[pr-summary-bar-styles]: https://github.com/polkadot-js/apps/pull/5891 +[pr-tag-styles]: https://github.com/polkadot-js/apps/pull/5893 +[pr-row-details]: https://github.com/polkadot-js/apps/pull/5894 +[pr-modals-duplication]: https://github.com/polkadot-js/apps/pull/5895 From 3c8a6059586fee4367916a8c8bfac1e466919874 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Mon, 27 Sep 2021 16:10:29 +0200 Subject: [PATCH 2/8] Add more links and descriptions --- .../polkadot-desktop-app-milestone-3.md | 33 +++++++++++++++++-- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index c92c09b17..952f63b37 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -7,15 +7,42 @@ | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | -| 1. | Accounts list redesign | [Figma designs](figma-designs) | TODO: Dev Handoff. After dev, we need to clean up for the sake of this Delivery | -| 2. | Accounts list implementation |
      1. [Summary bar][pr-summary-bar] (+ [styles][pr-summary-bar-styles])
      2. [Tag styles](pr-tag-styles)
      3. [Account collapsible details row][pr-row-details]
          4. | development in progress | +| 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | +| 2. | Accounts list implementation | https://polkadot.js.org/apps/#/accounts
          Source code changes mainly in [Accounts][code-accounts] - consult PRs for details.
          Automated tests - primarily in [Accounts][code-accounts-tests] - consult PRs for details |
          1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
          2. [Tag styles][pr-tag-styles]
          3. [Account collapsible details row][pr-row-details]
              4. | | 3. | Accounts sidebar implementation | TODO | Figma designs: work-in-progress | | 4. | Accounts App modals improvements |
              1. [Create/derive - remove code duplication][pr-modals-duplication]
              | development in progress | | 5. | Documentation updates | TODO | | +Almost every PR listed includes automated tests. + [figma-designs]: https://www.figma.com/file/5NAICV06SHNbbIoYhrUS3u/PolkaDot?node-id=2839%3A8075 +[code-accounts]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.tsx +[code-accounts-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.spec.ts [pr-summary-bar]: https://github.com/polkadot-js/apps/pull/5876 [pr-summary-bar-styles]: https://github.com/polkadot-js/apps/pull/5891 [pr-tag-styles]: https://github.com/polkadot-js/apps/pull/5893 -[pr-row-details]: https://github.com/polkadot-js/apps/pull/5894 +[pr-row-details]: https://github.com/polkadot-js/apps/pull/5975 [pr-modals-duplication]: https://github.com/polkadot-js/apps/pull/5895 +[apps-5439]: https://github.com/polkadot-js/apps/issues/5439 +[pr-style-address-balances]: https://github.com/polkadot-js/apps/pull/5897 +[pr-replace-sui-modal]: https://github.com/polkadot-js/apps/pull/5914 +[pr-accounts-sorting]: https://github.com/polkadot-js/apps/pull/5923 +[pr-replace-sui-popup]: https://github.com/polkadot-js/apps/pull/5924 +[pr-display-parent]: https://github.com/polkadot-js/apps/pull/5947 +[pr-keyboard-in-modal]: https://github.com/polkadot-js/apps/pull/5968 +[pr-flags-width]: https://github.com/polkadot-js/apps/pull/5957 +[pr-sidebar-links]: https://github.com/polkadot-js/apps/pull/5999 +[pr-sidebar-flags]: https://github.com/polkadot-js/apps/pull/6003 +[pr-replace-sui-popup]: https://github.com/polkadot-js/apps/pull/6007 +[pr-accounts-buttons]: https://github.com/polkadot-js/apps/pull/6012 +[pr-sidebar-edit]: https://github.com/polkadot-js/apps/pull/6049 +[pr-expand-hover]: https://github.com/polkadot-js/apps/pull/6052 +[pr-move-filter-input]: https://github.com/polkadot-js/apps/pull/6089 +[pr-sidebar-identity]: https://github.com/polkadot-js/apps/pull/6096 +[pr-sort-style]: https://github.com/polkadot-js/apps/pull/6099 +[pr-sidebar-width]: https://github.com/polkadot-js/apps/pull/6104 +[pr-sidebar-style-upper]: https://github.com/polkadot-js/apps/pull/6115 +[pr-row-details-addresses]: https://github.com/polkadot-js/apps/pull/6122 +[pr-filter-addresses]: https://github.com/polkadot-js/apps/pull/6155 +[pr-tests-output]: https://github.com/polkadot-js/apps/pull/6132 +[pr-filtering-bugfix]: https://github.com/polkadot-js/apps/pull/6166 From 4cd59864b4160c6d8d6dffdb81232fed8f95d199 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Thu, 30 Sep 2021 18:03:56 +0200 Subject: [PATCH 3/8] Summarize changes. --- deliveries/polkadot-desktop-app-milestone-3.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index 952f63b37..31755acec 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -8,13 +8,16 @@ | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | -| 2. | Accounts list implementation | https://polkadot.js.org/apps/#/accounts
              Source code changes mainly in [Accounts][code-accounts] - consult PRs for details.
              Automated tests - primarily in [Accounts][code-accounts-tests] - consult PRs for details |
              1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
              2. [Tag styles][pr-tag-styles]
              3. [Account collapsible details row][pr-row-details]
                  4. | -| 3. | Accounts sidebar implementation | TODO | Figma designs: work-in-progress | -| 4. | Accounts App modals improvements |
                  1. [Create/derive - remove code duplication][pr-modals-duplication]
                  | development in progress | +| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                  Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                  Automated tests - primarily in [App Accounts][code-accounts-tests] - consult PRs for details. |
                  1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                  2. [Tag styles][pr-tag-styles]
                  3. [Account collapsible details row][pr-row-details]
                  4. [Style address balances][pr-style-address-balances]
                  5. [Add accounts sorting][pr-accounts-sorting]
                  6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                  7. [Display parent above account name][pr-display-parent]
                  8. [Account actions popup redesign][pr-accounts-popup]
                  9. [Explorer links placement][pr-accounts-buttons]
                  10. [Add hover to expand button][pr-expand-hover]
                  11. [Account filter placement][pr-move-filter-input]
                  12. [Style sort input][pr-sort-style]
                  13. [Apply table style to Address Book][pr-row-details-addresses]
                  14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                  15. [Correct row coloring when filtering][pr-filtering-bugfix]
                      16. | +| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                      Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details. |
                      1. [Accounts flags placement][pr-flags-width]
                      2. [Icons for explorer links][pr-sidebar-links]
                      3. [Style flags][pr-sidebar-flags]
                      4. [Edit name and tags][pr-sidebar-edit]
                      5. [Style identity and balances sections][pr-sidebar-identity]
                      6. [Increase width][pr-sidebar-width]
                      7. [Style upper part][pr-sidebar-style-upper]
                      | +| 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
                      1. [Create/derive - remove code duplication][pr-modals-duplication]
                      2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
                      3. [Support keyboard in modals][pr-keyboard-in-modal]
                      | | 5. | Documentation updates | TODO | | -Almost every PR listed includes automated tests. +Most of the PRs listed include automated tests. +[app]: https://polkadot.js.org/apps +[app-accounts]: https://polkadot.js.org/apps/#/accounts +[app-address-book]: https://polkadot.js.org/apps/#/addresses [figma-designs]: https://www.figma.com/file/5NAICV06SHNbbIoYhrUS3u/PolkaDot?node-id=2839%3A8075 [code-accounts]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.tsx [code-accounts-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.spec.ts @@ -30,10 +33,11 @@ Almost every PR listed includes automated tests. [pr-replace-sui-popup]: https://github.com/polkadot-js/apps/pull/5924 [pr-display-parent]: https://github.com/polkadot-js/apps/pull/5947 [pr-keyboard-in-modal]: https://github.com/polkadot-js/apps/pull/5968 +[code-sidebar]: https://github.com/polkadot-js/apps/tree/master/packages/page-accounts/src/Sidebar [pr-flags-width]: https://github.com/polkadot-js/apps/pull/5957 [pr-sidebar-links]: https://github.com/polkadot-js/apps/pull/5999 [pr-sidebar-flags]: https://github.com/polkadot-js/apps/pull/6003 -[pr-replace-sui-popup]: https://github.com/polkadot-js/apps/pull/6007 +[pr-accounts-popup]: https://github.com/polkadot-js/apps/pull/6007 [pr-accounts-buttons]: https://github.com/polkadot-js/apps/pull/6012 [pr-sidebar-edit]: https://github.com/polkadot-js/apps/pull/6049 [pr-expand-hover]: https://github.com/polkadot-js/apps/pull/6052 From 92b904b30059e019e054e594c9f958d202d563dc Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Wed, 6 Oct 2021 15:35:26 +0200 Subject: [PATCH 4/8] Add PR and issues with Registrars --- deliveries/polkadot-desktop-app-milestone-3.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index 31755acec..5e50144a9 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -9,7 +9,7 @@ | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | | 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                      Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                      Automated tests - primarily in [App Accounts][code-accounts-tests] - consult PRs for details. |
                      1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                      2. [Tag styles][pr-tag-styles]
                      3. [Account collapsible details row][pr-row-details]
                      4. [Style address balances][pr-style-address-balances]
                      5. [Add accounts sorting][pr-accounts-sorting]
                      6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                      7. [Display parent above account name][pr-display-parent]
                      8. [Account actions popup redesign][pr-accounts-popup]
                      9. [Explorer links placement][pr-accounts-buttons]
                      10. [Add hover to expand button][pr-expand-hover]
                      11. [Account filter placement][pr-move-filter-input]
                      12. [Style sort input][pr-sort-style]
                      13. [Apply table style to Address Book][pr-row-details-addresses]
                      14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                      15. [Correct row coloring when filtering][pr-filtering-bugfix]
                          16. | -| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                          Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details. |
                          1. [Accounts flags placement][pr-flags-width]
                          2. [Icons for explorer links][pr-sidebar-links]
                          3. [Style flags][pr-sidebar-flags]
                          4. [Edit name and tags][pr-sidebar-edit]
                          5. [Style identity and balances sections][pr-sidebar-identity]
                          6. [Increase width][pr-sidebar-width]
                          7. [Style upper part][pr-sidebar-style-upper]
                          | +| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                          Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details. |
                          1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
                          2. [Accounts flags placement][pr-flags-width]
                          3. [Icons for explorer links][pr-sidebar-links]
                          4. [Style flags][pr-sidebar-flags]
                          5. [Edit name and tags][pr-sidebar-edit]
                          6. [Style identity and balances sections][pr-sidebar-identity]
                          7. [Increase width][pr-sidebar-width]
                          8. [Style upper part][pr-sidebar-style-upper]
                          | | 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
                          1. [Create/derive - remove code duplication][pr-modals-duplication]
                          2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
                          3. [Support keyboard in modals][pr-keyboard-in-modal]
                          | | 5. | Documentation updates | TODO | | @@ -50,3 +50,5 @@ Most of the PRs listed include automated tests. [pr-filter-addresses]: https://github.com/polkadot-js/apps/pull/6155 [pr-tests-output]: https://github.com/polkadot-js/apps/pull/6132 [pr-filtering-bugfix]: https://github.com/polkadot-js/apps/pull/6166 +[pr-registrars]: https://github.com/polkadot-js/apps/pull/6157 +[apps-2297-registrars]: https://github.com/polkadot-js/apps/issues/2297 From 4d41db8cd46e47a9bf1f6bf94049683d155c5182 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Wed, 6 Oct 2021 16:16:01 +0200 Subject: [PATCH 5/8] Link more PRs --- deliveries/polkadot-desktop-app-milestone-3.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index 5e50144a9..bc98db253 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -8,7 +8,7 @@ | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | -| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                          Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                          Automated tests - primarily in [App Accounts][code-accounts-tests] - consult PRs for details. |
                          1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                          2. [Tag styles][pr-tag-styles]
                          3. [Account collapsible details row][pr-row-details]
                          4. [Style address balances][pr-style-address-balances]
                          5. [Add accounts sorting][pr-accounts-sorting]
                          6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                          7. [Display parent above account name][pr-display-parent]
                          8. [Account actions popup redesign][pr-accounts-popup]
                          9. [Explorer links placement][pr-accounts-buttons]
                          10. [Add hover to expand button][pr-expand-hover]
                          11. [Account filter placement][pr-move-filter-input]
                          12. [Style sort input][pr-sort-style]
                          13. [Apply table style to Address Book][pr-row-details-addresses]
                          14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                          15. [Correct row coloring when filtering][pr-filtering-bugfix]
                              16. | +| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                              Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                              Automated tests - primarily in [App Accounts][code-accounts-tests] - consult PRs for details. |
                              1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                              2. [Tag styles][pr-tag-styles]
                              3. [Account collapsible details row][pr-row-details]
                              4. [Style address balances][pr-style-address-balances]
                              5. [Add accounts sorting][pr-accounts-sorting]
                              6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                              7. [Display parent above account name][pr-display-parent]
                              8. [Account actions popup redesign][pr-accounts-popup]
                              9. [Explorer links placement][pr-accounts-buttons]
                              10. [Add hover to expand button][pr-expand-hover]
                              11. [Account filter placement][pr-move-filter-input]
                              12. [Style sort input][pr-sort-style]
                              13. [Apply table style to Address Book][pr-row-details-addresses]
                              14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                              15. [Correct row coloring when filtering][pr-filtering-bugfix]
                              16. [Style account badges][pr-badges]
                              17. [Style table headers][pr-table-headers]
                              18. [Style redeemable balances in expanded view][pr-redeemable]
                                  19. | | 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                                  Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details. |
                                  1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
                                  2. [Accounts flags placement][pr-flags-width]
                                  3. [Icons for explorer links][pr-sidebar-links]
                                  4. [Style flags][pr-sidebar-flags]
                                  5. [Edit name and tags][pr-sidebar-edit]
                                  6. [Style identity and balances sections][pr-sidebar-identity]
                                  7. [Increase width][pr-sidebar-width]
                                  8. [Style upper part][pr-sidebar-style-upper]
                                  | | 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
                                  1. [Create/derive - remove code duplication][pr-modals-duplication]
                                  2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
                                  3. [Support keyboard in modals][pr-keyboard-in-modal]
                                  | | 5. | Documentation updates | TODO | | @@ -52,3 +52,6 @@ Most of the PRs listed include automated tests. [pr-filtering-bugfix]: https://github.com/polkadot-js/apps/pull/6166 [pr-registrars]: https://github.com/polkadot-js/apps/pull/6157 [apps-2297-registrars]: https://github.com/polkadot-js/apps/issues/2297 +[pr-badges]: https://github.com/polkadot-js/apps/pull/6208 +[pr-table-headers]: https://github.com/polkadot-js/apps/pull/6180 +[pr-redeemable]: https://github.com/polkadot-js/apps/pull/6220 From f3f8bdcb6306678a699973b3750e96872f4eb385 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Wed, 6 Oct 2021 16:19:18 +0200 Subject: [PATCH 6/8] More tests links --- deliveries/polkadot-desktop-app-milestone-3.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index bc98db253..0e289a6f8 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -8,8 +8,8 @@ | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | -| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                                  Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                                  Automated tests - primarily in [App Accounts][code-accounts-tests] - consult PRs for details. |
                                  1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                                  2. [Tag styles][pr-tag-styles]
                                  3. [Account collapsible details row][pr-row-details]
                                  4. [Style address balances][pr-style-address-balances]
                                  5. [Add accounts sorting][pr-accounts-sorting]
                                  6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                                  7. [Display parent above account name][pr-display-parent]
                                  8. [Account actions popup redesign][pr-accounts-popup]
                                  9. [Explorer links placement][pr-accounts-buttons]
                                  10. [Add hover to expand button][pr-expand-hover]
                                  11. [Account filter placement][pr-move-filter-input]
                                  12. [Style sort input][pr-sort-style]
                                  13. [Apply table style to Address Book][pr-row-details-addresses]
                                  14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                                  15. [Correct row coloring when filtering][pr-filtering-bugfix]
                                  16. [Style account badges][pr-badges]
                                  17. [Style table headers][pr-table-headers]
                                  18. [Style redeemable balances in expanded view][pr-redeemable]
                                      19. | -| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                                      Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details. |
                                      1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
                                      2. [Accounts flags placement][pr-flags-width]
                                      3. [Icons for explorer links][pr-sidebar-links]
                                      4. [Style flags][pr-sidebar-flags]
                                      5. [Edit name and tags][pr-sidebar-edit]
                                      6. [Style identity and balances sections][pr-sidebar-identity]
                                      7. [Increase width][pr-sidebar-width]
                                      8. [Style upper part][pr-sidebar-style-upper]
                                      | +| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                                      Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                                      Automated tests - primarily in [App Accounts][code-accounts-tests], applied also to Address Book - consult PRs for details. |
                                      1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                                      2. [Tag styles][pr-tag-styles]
                                      3. [Account collapsible details row][pr-row-details]
                                      4. [Style address balances][pr-style-address-balances]
                                      5. [Add accounts sorting][pr-accounts-sorting]
                                      6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                                      7. [Display parent above account name][pr-display-parent]
                                      8. [Account actions popup redesign][pr-accounts-popup]
                                      9. [Explorer links placement][pr-accounts-buttons]
                                      10. [Add hover to expand button][pr-expand-hover]
                                      11. [Account filter placement][pr-move-filter-input]
                                      12. [Style sort input][pr-sort-style]
                                      13. [Apply table style to Address Book][pr-row-details-addresses]
                                      14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                                      15. [Correct row coloring when filtering][pr-filtering-bugfix]
                                      16. [Style account badges][pr-badges]
                                      17. [Style table headers][pr-table-headers]
                                      18. [Style redeemable balances in expanded view][pr-redeemable]
                                          19. | +| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                                          Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details.
                                          Automated tests in [Sidebar.spec][code-sidebar-tests] |
                                          1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
                                          2. [Accounts flags placement][pr-flags-width]
                                          3. [Icons for explorer links][pr-sidebar-links]
                                          4. [Style flags][pr-sidebar-flags]
                                          5. [Edit name and tags][pr-sidebar-edit]
                                          6. [Style identity and balances sections][pr-sidebar-identity]
                                          7. [Increase width][pr-sidebar-width]
                                          8. [Style upper part][pr-sidebar-style-upper]
                                          | | 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
                                          1. [Create/derive - remove code duplication][pr-modals-duplication]
                                          2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
                                          3. [Support keyboard in modals][pr-keyboard-in-modal]
                                          | | 5. | Documentation updates | TODO | | @@ -21,6 +21,7 @@ Most of the PRs listed include automated tests. [figma-designs]: https://www.figma.com/file/5NAICV06SHNbbIoYhrUS3u/PolkaDot?node-id=2839%3A8075 [code-accounts]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.tsx [code-accounts-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.spec.ts +[code-sidebar-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Sidebar/Sidebar.spec.tsx [pr-summary-bar]: https://github.com/polkadot-js/apps/pull/5876 [pr-summary-bar-styles]: https://github.com/polkadot-js/apps/pull/5891 [pr-tag-styles]: https://github.com/polkadot-js/apps/pull/5893 From eae901f20e8788afa613941fe5ac21ea1c5243b7 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Fri, 15 Oct 2021 14:04:40 +0200 Subject: [PATCH 7/8] Add docs and PR open status. --- deliveries/polkadot-desktop-app-milestone-3.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index 0e289a6f8..fe690dcba 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -8,10 +8,10 @@ | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | -| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                                          Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                                          Automated tests - primarily in [App Accounts][code-accounts-tests], applied also to Address Book - consult PRs for details. |
                                          1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles]
                                          2. [Tag styles][pr-tag-styles]
                                          3. [Account collapsible details row][pr-row-details]
                                          4. [Style address balances][pr-style-address-balances]
                                          5. [Add accounts sorting][pr-accounts-sorting]
                                          6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                                          7. [Display parent above account name][pr-display-parent]
                                          8. [Account actions popup redesign][pr-accounts-popup]
                                          9. [Explorer links placement][pr-accounts-buttons]
                                          10. [Add hover to expand button][pr-expand-hover]
                                          11. [Account filter placement][pr-move-filter-input]
                                          12. [Style sort input][pr-sort-style]
                                          13. [Apply table style to Address Book][pr-row-details-addresses]
                                          14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                                          15. [Correct row coloring when filtering][pr-filtering-bugfix]
                                          16. [Style account badges][pr-badges]
                                          17. [Style table headers][pr-table-headers]
                                          18. [Style redeemable balances in expanded view][pr-redeemable]
                                              19. | +| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
                                              Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
                                              Automated tests - primarily in [App Accounts][code-accounts-tests], applied also to Address Book - consult PRs for details. |
                                              1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles] (still open)
                                              2. [Tag styles][pr-tag-styles]
                                              3. [Account collapsible details row][pr-row-details]
                                              4. [Style address balances][pr-style-address-balances]
                                              5. [Add accounts sorting][pr-accounts-sorting]
                                              6. [Replace SUI popup with custom one][pr-replace-sui-popup]
                                              7. [Display parent above account name][pr-display-parent]
                                              8. [Account actions popup redesign][pr-accounts-popup]
                                              9. [Explorer links placement][pr-accounts-buttons]
                                              10. [Add hover to expand button][pr-expand-hover]
                                              11. [Account filter placement][pr-move-filter-input]
                                              12. [Style sort input][pr-sort-style]
                                              13. [Apply table style to Address Book][pr-row-details-addresses]
                                              14. [Apply button and filter styles to Address Book][pr-filter-addresses]
                                              15. [Correct row coloring when filtering][pr-filtering-bugfix]
                                              16. [Style account badges][pr-badges]
                                              17. [Style table headers][pr-table-headers] (still open)
                                              18. [Style redeemable balances in expanded view][pr-redeemable]
                                                  19. | | 3. | Accounts sidebar implementation | Click on any account in [apps][app].
                                                  Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details.
                                                  Automated tests in [Sidebar.spec][code-sidebar-tests] |
                                                  1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
                                                  2. [Accounts flags placement][pr-flags-width]
                                                  3. [Icons for explorer links][pr-sidebar-links]
                                                  4. [Style flags][pr-sidebar-flags]
                                                  5. [Edit name and tags][pr-sidebar-edit]
                                                  6. [Style identity and balances sections][pr-sidebar-identity]
                                                  7. [Increase width][pr-sidebar-width]
                                                  8. [Style upper part][pr-sidebar-style-upper]
                                                  | | 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
                                                  1. [Create/derive - remove code duplication][pr-modals-duplication]
                                                  2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
                                                  3. [Support keyboard in modals][pr-keyboard-in-modal]
                                                  | -| 5. | Documentation updates | TODO | | +| 5. | Documentation updates | Updates in [Multisig section][doc-multisig] of the wiki | [PR #2724][pr-doc-multisig] in wiki repo. | Most of the PRs listed include automated tests. @@ -56,3 +56,5 @@ Most of the PRs listed include automated tests. [pr-badges]: https://github.com/polkadot-js/apps/pull/6208 [pr-table-headers]: https://github.com/polkadot-js/apps/pull/6180 [pr-redeemable]: https://github.com/polkadot-js/apps/pull/6220 +[doc-multisig]: https://wiki.polkadot.network/docs/learn-accounts#example-with-polkadotjs +[pr-doc-multisig]: https://github.com/w3f/polkadot-wiki/pull/2724 From a319baf46af6d4542d175818997b058426860198 Mon Sep 17 00:00:00 2001 From: Krzysztof Jelski Date: Fri, 15 Oct 2021 15:53:46 +0200 Subject: [PATCH 8/8] Add screenshots --- deliveries/polkadot-desktop-app-milestone-3.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md index fe690dcba..df1c56819 100644 --- a/deliveries/polkadot-desktop-app-milestone-3.md +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -5,6 +5,16 @@ * **Application Document:** [link](https://github.com/w3f/Grants-Program/blob/master/applications/polkadot-desktop-app.md) * **Milestone Number:** 3 +## Visual summary of the changes + +| | Before | After | +| ------- | -------| ----- | +| Accounts | ![image](https://user-images.githubusercontent.com/430616/137498444-0ead994f-a541-482d-a9cb-62c7aeb09918.png) | ![image](https://user-images.githubusercontent.com/430616/137498472-52ab3a62-8eb7-4afc-894e-a1768c68427f.png) | +| Popup | ![image](https://user-images.githubusercontent.com/430616/137498521-c03a3c56-79c0-4990-80f4-3f51c13d349a.png) | ![image](https://user-images.githubusercontent.com/430616/137498539-ecc5afa1-d2bf-4db3-bf87-08b5cd9318ab.png) | +| Sidebar | ![image](https://user-images.githubusercontent.com/430616/137497848-c3e86adc-c713-4313-9e68-d5503089ad1b.png) | ![image](https://user-images.githubusercontent.com/430616/137497997-973064d3-8941-4d70-a954-01a54b215078.png) | + +## Detailed delivery description + | Number | Deliverable | Link | Notes | | --- | -------------------------------- | ------------- |------ | | 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) |