-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The definition of font-width
is missing from ED CSS Fonts (4)
#1130
Comments
There seems to be a problem indeed, see the error in the crawl result, I'll look into it. Thanks for the report! I also created #1131 to add a notification mechanism. The crawler records the error and reuses previous extracts when a problem occurs, which is nice but also hides the error... |
Crash is due to an empty line at the end of the table that defines I do not know how that empty line ended up in there. I suspect that is triggered by the HTML comment that exists in the source, but then that comment has been around for years, and re-generating the spec with the lastest version of Bikeshed does not seem to produce that empty line. There have been various code updates made to Bikeshed in the past couple of days, perhaps the spec got generated with an intermediary version. Anyway, I'll make code extraction ignore empty lines to avoid crashes! |
I cannot reproduce it, but Bikeshed generated an empty line at the end of the table definition of `font-style` in css-fonts-4. The extraction logic did not expect that and crashed. This update makes the extraction logic more resilient by ignoring empty lines. Via w3c/webref#1130
I cannot reproduce it, but Bikeshed generated an empty line at the end of the table definition of `font-style` in css-fonts-4. The extraction logic did not expect that and crashed. This update makes the extraction logic more resilient by ignoring empty lines. Via w3c/webref#1130
Ah, I forgot to check that crawl result, sorry. You spotted the problem way quicker than I could have though.
Did you check with the online tool or with a local install? I do not know if the former uses the latest version. Thank you! |
Both ;) But I had somehow failed to update my local install. Problem reported to Bikeshed! Webref's data now updated with the new The css-fonts-4 spec is still "broken" in the sense that it does not define the previous |
In w3c/csswg-drafts@b0660ee, the CSS property
font-stretch
was renamed tofont-width
in the ED of CSS Fonts 4, andfont-stretch
became a legacy alias offont-width
.But
ed/css/css-fonts.json
still does not include the definition offont-width
, 2 days after this change.I do not mind waiting several days for the definitions to mirror what is actually included online in the specs, but I suspect there is a problem because, in my experience, a change that becomes visible in the spec is usually reflected in the next crawl.
The text was updated successfully, but these errors were encountered: