Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The definition of font-width is missing from ED CSS Fonts (4) #1130

Closed
cdoublev opened this issue Jan 26, 2024 · 4 comments
Closed

The definition of font-width is missing from ED CSS Fonts (4) #1130

cdoublev opened this issue Jan 26, 2024 · 4 comments

Comments

@cdoublev
Copy link

In w3c/csswg-drafts@b0660ee, the CSS property font-stretch was renamed to font-width in the ED of CSS Fonts 4, and font-stretch became a legacy alias of font-width.

But ed/css/css-fonts.json still does not include the definition of font-width, 2 days after this change.

I do not mind waiting several days for the definitions to mirror what is actually included online in the specs, but I suspect there is a problem because, in my experience, a change that becomes visible in the spec is usually reflected in the next crawl.

@tidoust
Copy link
Member

tidoust commented Jan 26, 2024

There seems to be a problem indeed, see the error in the crawl result, I'll look into it. Thanks for the report!

I also created #1131 to add a notification mechanism. The crawler records the error and reuses previous extracts when a problem occurs, which is nice but also hides the error...

@tidoust
Copy link
Member

tidoust commented Jan 26, 2024

Crash is due to an empty line at the end of the table that defines font-style.

I do not know how that empty line ended up in there. I suspect that is triggered by the HTML comment that exists in the source, but then that comment has been around for years, and re-generating the spec with the lastest version of Bikeshed does not seem to produce that empty line. There have been various code updates made to Bikeshed in the past couple of days, perhaps the spec got generated with an intermediary version.

Anyway, I'll make code extraction ignore empty lines to avoid crashes!

tidoust added a commit to w3c/reffy that referenced this issue Jan 26, 2024
I cannot reproduce it, but Bikeshed generated an empty line at the end of the
table definition of `font-style` in css-fonts-4. The extraction logic did not
expect that and crashed.

This update makes the extraction logic more resilient by ignoring empty lines.

Via w3c/webref#1130
tidoust added a commit to w3c/reffy that referenced this issue Jan 26, 2024
tidoust added a commit to w3c/reffy that referenced this issue Jan 26, 2024
I cannot reproduce it, but Bikeshed generated an empty line at the end of the
table definition of `font-style` in css-fonts-4. The extraction logic did not
expect that and crashed.

This update makes the extraction logic more resilient by ignoring empty lines.

Via w3c/webref#1130
@cdoublev
Copy link
Author

Ah, I forgot to check that crawl result, sorry. You spotted the problem way quicker than I could have though.

re-generating the spec with the lastest version of Bikeshed does not seem to produce that empty line

Did you check with the online tool or with a local install? I do not know if the former uses the latest version.

Thank you!

@tidoust
Copy link
Member

tidoust commented Jan 26, 2024

Did you check with the online tool or with a local install? I do not know if the former uses the latest version.

Both ;) But I had somehow failed to update my local install. Problem reported to Bikeshed!

Webref's data now updated with the new font-weight property.

The css-fonts-4 spec is still "broken" in the sense that it does not define the previous font-stretch property with the right definition type (links to font-stretch end up linking to the /TR version as a result). I'll report that as well.

@tidoust tidoust closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants