From c0f828ba303b0f6704ee87a78381a15aa649f7d0 Mon Sep 17 00:00:00 2001
From: James Graham <james@hoppipolla.co.uk>
Date: Wed, 17 Jul 2024 13:53:51 +0100
Subject: [PATCH 1/2] Fix some small problems with set window rect changes

* Restore handling both missing and null values for parameters.

* Fix some grammar errors.
---
 index.html | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)

diff --git a/index.html b/index.html
index 7d92a662..0b26bd59 100644
--- a/index.html
+++ b/index.html
@@ -4046,28 +4046,39 @@ <h4><dfn>Set Window Rect</dfn></h4>
   <a>getting a property</a> named "<code>width</code>"
   from <var>parameters</var></a>.
 
+ <li><p>If <var>width</var> is <a>undefined</a> let <var>width</var>
+  be null.
+
  <li><p>Let <var>height</var> be the result of
   <a>getting a property</a> named "<code>height</code>"
   from <var>parameters</var>.
 
+ <li><p>If <var>height</var> is <a>undefined</a> let <var>height</var>
+  be null.
+
  <li><p>Let <var>x</var> be the result of <a>getting a property</a>
   named "<code>x</code>" from <var>parameters</var>.
 
+ <li><p>If <var>x</var> is <a>undefined</a> let <var>x</var> be null.
+
  <li><p>Let <var>y</var> be the result of <a>getting a property</a>
   named "<code>y</code>" from <var>parameters</var>.
 
- <li><p>If <var>width</var> or <var>height</var> is neither <a>undefined</a>
-  nor a <a>Number</a> from 0 to 2<sup>31</sup> − 1,
-  return <a>error</a> with <a>error code</a> <a>invalid argument</a>.
+ <li><p>If <var>y</var> is <a>undefined</a> let <var>y</var> be null.
 
- <li><p>If <var>x</var> or <var>y</var> is neither <a>undefined</a>
-  nor a <a>Number</a> from −(2<sup>31</sup>) to 2<sup>31</sup> − 1,
+ <li><p>If <var>width</var> or <var>height</var> is neither null, nor
+  a <a>Number</a> from 0 to 2<sup>31</sup> − 1, return <a>error</a>
+  with <a>error code</a> <a>invalid argument</a>.
+
+ <li><p>If <var>x</var> or <var>y</var> is neither null, nor
+  a <a>Number</a> from −(2<sup>31</sup>) to 2<sup>31</sup> − 1,
   return <a>error</a> with <a>error code</a> <a>invalid argument</a>.
 
  <li><p>If the <a>remote end</a> does not support
   the <a>Set Window Rect</a> <a>command</a> for
-  <var>session</var>&apos;s <a>current top-level browsing context</a> for any reason,
-  return <a>error</a> with <a>error code</a> <a>unsupported operation</a>.
+  <var>session</var>&apos;s <a>current top-level browsing context</a>
+  for any reason, return <a>error</a> with <a>error
+  code</a> <a>unsupported operation</a>.
 
   <p class="note">In case the <a>Set Window Rect</a> command is
   partially supported (i.e. some combinations of arguments are
@@ -4092,12 +4103,12 @@ <h4><dfn>Set Window Rect</dfn></h4>
  of <var>window</var>:
 
   <ol>
-   <li><p>If <var>width</var> is not <a>undefined</a>, set the width,
+   <li><p>If <var>width</var> is not null, set the width,
     in <a>CSS pixels</a>, of <var>window</var>, including
     any <a>browser chrome</a> and externally drawn window decorations,
     to a value that is as close as possible to <var>width</var>.
 
-  <li><p>If <var>height</var> is not <a>undefined</a>, set the height,
+  <li><p>If <var>height</var> is not null, set the height,
    in <a>CSS pixels</a>, of <var>window</var>, including
    any <a>browser chrome</a> and externally drawn window decorations,
    to a value that is as close as possible to <var>height</var>.
@@ -4127,13 +4138,13 @@ <h4><dfn>Set Window Rect</dfn></h4>
  <li><p>If the implementation is able to set the position of <var>window</var>:
 
   <ol>
-   <li><p>If <var>x</var> is not <a>undefined</a>, run specific
-    steps set the x-coordinate of the left edge of <var>window</var>
-    to a value that is as close as possible to <var>x</var>.
+   <li><p>If <var>x</var> is not null, set the x-coordinate of the
+    left edge of <var>window</var> to a value that is as close as
+    possible to <var>x</var>.
 
-   <li><p>If <var>y</var> is not <a>undefined</a>, run specific
-    steps set the y-coordinate of the top edge of <var>window</var> to
-    a value that is as close as possible to <var>y</var>.
+   <li><p>If <var>y</var> is not null, set the y-coordinate of the top
+    edge of <var>window</var> to a value that is as close as possible
+    to <var>y</var>.
   </ol>
 
   <aside class=note>

From ee975a4d251c6ae29eb44985970bb319ceaba79a Mon Sep 17 00:00:00 2001
From: jgraham <james@hoppipolla.co.uk>
Date: Wed, 17 Jul 2024 14:55:20 +0100
Subject: [PATCH 2/2] Apply suggestions from code review

Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
---
 index.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/index.html b/index.html
index 0b26bd59..c0e35b7d 100644
--- a/index.html
+++ b/index.html
@@ -4046,25 +4046,25 @@ <h4><dfn>Set Window Rect</dfn></h4>
   <a>getting a property</a> named "<code>width</code>"
   from <var>parameters</var></a>.
 
- <li><p>If <var>width</var> is <a>undefined</a> let <var>width</var>
+ <li><p>If <var>width</var> is <a>undefined</a>, let <var>width</var>
   be null.
 
  <li><p>Let <var>height</var> be the result of
   <a>getting a property</a> named "<code>height</code>"
   from <var>parameters</var>.
 
- <li><p>If <var>height</var> is <a>undefined</a> let <var>height</var>
+ <li><p>If <var>height</var> is <a>undefined</a>, let <var>height</var>
   be null.
 
  <li><p>Let <var>x</var> be the result of <a>getting a property</a>
   named "<code>x</code>" from <var>parameters</var>.
 
- <li><p>If <var>x</var> is <a>undefined</a> let <var>x</var> be null.
+ <li><p>If <var>x</var> is <a>undefined</a>, let <var>x</var> be null.
 
  <li><p>Let <var>y</var> be the result of <a>getting a property</a>
   named "<code>y</code>" from <var>parameters</var>.
 
- <li><p>If <var>y</var> is <a>undefined</a> let <var>y</var> be null.
+ <li><p>If <var>y</var> is <a>undefined</a>, let <var>y</var> be null.
 
  <li><p>If <var>width</var> or <var>height</var> is neither null, nor
   a <a>Number</a> from 0 to 2<sup>31</sup> − 1, return <a>error</a>