Put trusted type first when declaring union in IDL files #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @koto @lukewarlow |
lukewarlow
requested changes
Nov 15, 2024
This is for consistency with how it is done in the HTML specification and in the PR to DOM (whatwg/dom#1268). This is not web-exposed but may matter for implementations. For example, they may generate different C++ structure to represent `(TrustedHTML or DOMString)` and `(DOMString or TrustedHTML)`.
fred-wang
force-pushed
the
union-order
branch
from
904b5fe
to
8e1fa0f
Compare
github-actions bot
added a commit
that referenced
this pull request
Nov 18, 2024
SHA: f97dbe9 Reason: push, by koto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for consistency with how it is done in the HTML specification and in the PR to DOM (whatwg/dom#1268). This is not web-exposed but may matter for implementations. For example, they may generate different C++ structure to represent
(TrustedHTML or DOMString)and(DOMString or TrustedHTML).Preview | Diff