Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses metadata test failure on Issue #112 #122

Merged
merged 4 commits into from
May 24, 2021

Conversation

shigeya
Copy link
Contributor

@shigeya shigeya commented May 22, 2021

This is a follow-up PR that addresses issues mentioned in Issue #112 to support the test of multi-level map structure in DID Metadata tests using the new toBeDidDocumentMap matcher.

It passes most of the tests in the did-core-properties test suite for did:orb mentioned in PR #117.

- Map and Set objects are not treated correctly
- Added test cases with hierarchical objects
@shigeya
Copy link
Contributor Author

shigeya commented May 23, 2021

A few fixes related to this PR added also.

@msporny msporny merged commit 329cc57 into w3c:main May 24, 2021
@shigeya shigeya deleted the shigeya-fix-issue-112-part2 branch May 24, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants