Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entries for did:ion #120

Merged
merged 6 commits into from
May 26, 2021
Merged

Add entries for did:ion #120

merged 6 commits into from
May 26, 2021

Conversation

csuwildcat
Copy link
Contributor

@csuwildcat csuwildcat commented May 21, 2021

I ran the tests and the generated report shows failures for the following:

  1. 5.x Core Properties - not accepting relative paths (#some-id) as valid entries for key identifiers
  2. 5.x Core Properties - controller field not allowed to be blank in key descriptor, even though JSON-LD populates it, and the base URI assumption should hold (we can modify our stuff, but it's just a bit wonky that base URI doesn't carry here)
  3. 7.3 Metadata Structure - 2x instances of failure on this, but no clue why this is failing, or what it even means: Tests cannot be nested. Test "7.3 Metadata Structure - The structure used to communicate this metadata MUST be a map of properties."

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 26, 2021, 3:22 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

📡 HTTP Error 404: https://rawcdn.githack.com/csuwildcat/did-test-suite/df8d2d2dec4b754a6f4edf3ff6aa2cca4bc91512/index.html

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@csuwildcat csuwildcat requested review from msporny and OR13 as code owners May 21, 2021 18:21
@csuwildcat
Copy link
Contributor Author

I would love clarification on the specific directives around the base URI of the DID document, and what we are supposed to do to if we want to use a relative URL that leverages the base URI of a DID Document.

@shigeya
Copy link
Contributor

shigeya commented May 22, 2021

@csuwildcat I addressed issues in Sec 7.3 in PR #122, it was not property work for nested map/array objects.

@shigeya
Copy link
Contributor

shigeya commented May 22, 2021

The remaining errors are:

  1. Current test code only allows a full DID URL, not a relative DID URL. Verification Method's ID value should allow relative DID URL.
  2. "controller" value needs to be non-empty, but it's empty.

I created a PR #123 to address the former issue.

@msporny
Copy link
Member

msporny commented May 24, 2021

@csuwildcat, merge conflicts, please fix.

@OR13
Copy link
Contributor

OR13 commented May 24, 2021

@csuwildcat please resolve merge confs

@csuwildcat
Copy link
Contributor Author

@OR13 should those output files be gitignored?

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csuwildcat please remove index.html and test-vectors/did-spec.latest.json -- we are no longer tracking autogenerated files in the github repo... they will be produced on a Github Action / nightly build basis going forward.

@csuwildcat
Copy link
Contributor Author

@msporny everything appears to be in order now, so can we please merge while there are no conflicts?

@csuwildcat
Copy link
Contributor Author

5b0v2y

@msporny msporny merged commit cff8582 into w3c:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants