-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entries for did:ion #120
Conversation
I would love clarification on the specific directives around the base URI of the DID document, and what we are supposed to do to if we want to use a relative URL that leverages the base URI of a DID Document. |
@csuwildcat I addressed issues in Sec 7.3 in PR #122, it was not property work for nested map/array objects. |
The remaining errors are:
I created a PR #123 to address the former issue. |
@csuwildcat, merge conflicts, please fix. |
@csuwildcat please resolve merge confs |
@OR13 should those output files be gitignored? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csuwildcat please remove index.html and test-vectors/did-spec.latest.json -- we are no longer tracking autogenerated files in the github repo... they will be produced on a Github Action / nightly build basis going forward.
@msporny everything appears to be in order now, so can we please merge while there are no conflicts? |
I ran the tests and the generated report shows failures for the following:
#some-id
) as valid entries for key identifiersTests cannot be nested. Test "7.3 Metadata Structure - The structure used to communicate this metadata MUST be a map of properties."
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on May 26, 2021, 3:22 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.