Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level index.html is gone #137

Closed
shigeya opened this issue May 27, 2021 · 3 comments
Closed

Top level index.html is gone #137

shigeya opened this issue May 27, 2021 · 3 comments

Comments

@shigeya
Copy link
Contributor

shigeya commented May 27, 2021

Merging the PR #120 removing top level index.html file and test data JSON file.

For reporting purposes, the report generator relies on the index.html as a template.

If the removal of the file at the top level is an accident, I will add it with the latest result.

If the removal is intentional, I will create a template file, and also will commit the latest test result (for reporting purposes, not for implementers to do) in a subdirectory, maybe, packages/did-core-test-server/latest_report.

Any suggestions?

@msporny
Copy link
Member

msporny commented May 28, 2021

If the removal is intentional, I will create a template file, and also will commit the latest test result (for reporting purposes, not for implementers to do) in a subdirectory, maybe, packages/did-core-test-server/latest_report.

Yes, please do this -- add a template file.

@shigeya
Copy link
Contributor Author

shigeya commented May 28, 2021

I read this after commenting on the other issue.

Then, where is the file generated, and the name of the file? index.html at the root of the repository is ok?

@shigeya
Copy link
Contributor Author

shigeya commented May 28, 2021

Understood the situation and addressed it in PR #138. closing.

@shigeya shigeya closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants