Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples 41-48 suggest tableSchema can have array content #855

Open
mgoodhand opened this issue Aug 18, 2017 · 3 comments · May be fixed by #857
Open

Examples 41-48 suggest tableSchema can have array content #855

mgoodhand opened this issue Aug 18, 2017 · 3 comments · May be fixed by #857
Assignees
@gkellogg @danbri @JeniT
Labels
Editorial Errata Metadata vocabulary document

Comments

@mgoodhand
Copy link

Section 6.1 of "Metadata Vocabulary for Tabular Data" has a number of examples that suggest tableSchema can have array content, e.g.

{
  "@context": { "http://www.w3.org/ns/csvw", { "@language": "en" } },
  "@type": "Table",
  "url": "http://example.com/table.csv",
  "tableSchema": [...],
  "dc:title": "The title of this Table"
}

https://www.w3.org/TR/2015/REC-tabular-metadata-20151217/#h-normalization-examples

The ellipses are clear enough, but I'd expect them to appear in an object (curly braces) rather than an array (square brackets), e.g.

{
  "@context": { "http://www.w3.org/ns/csvw", { "@language": "en" } },
  "@type": "Table",
  "url": "http://example.com/table.csv",
  "tableSchema": {...},
  "dc:title": "The title of this Table"
}
gkellogg added a commit that referenced this issue Aug 19, 2017
@gkellogg
Fix examples using "tableSchema": [...] to "tableSchema": {...}, …
2df4aa0 
…which is more appropriate given that tableSchema is single-valued.

Fixes #855.
@gkellogg gkellogg linked a pull request Aug 19, 2017 that will close this issue
Open
@gkellogg
Copy link
Member

It's not incorrect to use [...], but as tableSchema is single valued, it is probably better to use an object form. This also fixes a use in csv2json.

@iherman
Copy link
Member

iherman commented Aug 20, 2017 •
edited
Loading

Summary: (by @gkellogg) "It's not incorrect to use [...], but as tableSchema is single valued, it is probably better to use an object form. This also fixes a use in csv2json.". A separate PR (#857) is on file.

@mgoodhand
Copy link
Author

Thanks for the prompt review and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkellogg gkellogg

@danbri danbri

@JeniT JeniT

Labels
Editorial Errata Metadata vocabulary document
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix examples using "tableSchema": [...] w3c/csvw
5 participants
@gkellogg @danbri @JeniT @iherman @mgoodhand