Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Clarify / make consistent naming steps for HTML form controls #2395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Dec 9, 2024

This should not contain any normative changes

the "other form controls" is not touched in this update - as there are also other pending PRs - re select element - that start breaking that apart.

- Updates the listed inputs and button types to steps more consistent in wording.
- incorporates w3c/accname#246 into the label steps for the mentioned form controls
- starting to migrate from just using "subtree" to "text equivalent computation of the element's subtree" - as the simple use of 'subtree' has come up in a handful of reviews for html aam naming steps

the "other form controls" is not touched in this update - as there are also other pending PRs - re select element - that start breaking that apart.
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 03ddaad
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67574bcd6c874300088a83c5
😎 Deploy Preview https://deploy-preview-2395--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

scottaohara added a commit that referenced this pull request Dec 11, 2024
keeping in alignment with wording updates in #2395
@spectranaut spectranaut changed the title Clarify / make consistent naming steps for HTML form controls Editorial: Clarify / make consistent naming steps for HTML form controls Dec 12, 2024
Copy link
Contributor

@accdc accdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. :)

use the value of the control's `value` attribute.</li>
<li>
For `input type=submit` and `type=reset`:
if the <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a> is still empty, and the `value` attribute is unspecified use the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit, maybe add comma for readability and consistency

Suggested change
if the <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a> is still empty, and the `value` attribute is unspecified use the
if the <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a> is still empty, and the `value` attribute is unspecified, use the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants