add sectionheader and sectionfooter roles #1931

scottaohara · 2023-05-09T19:26:39Z

adds proposed header and footer roles to allow authors to identify areas of the page that would fit the more general HTML definition for the elements of the same name (and would not be considered landmark elements).

These would also allow for the respective HTML elements to expose these new roles - essentially 'renamed' group roles - if they are given properties important to accessibility (focusable, named) but are not meeting the conditions to be exposed as banner / contentinfo landmarks. The alternative is to just expose the elements as groups, which is doable, but arguably also overloads the use of the group role.

Closes #1915

Implementation tracking

"author MUST" tests: n/a
"user agent MUST" tests (wpt): Core-AAM: add tests for sectionheader and sectionfooter web-platform-tests/wpt#45916
Browser implementations (link to issue or when done, link to commit):
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=273325
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1893684
- Blink: https://issues.chromium.org/issues/337094897
Does this need AT implementations? n/a
MDN changes

Preview | Diff

scottaohara

need to remove instances of referring to fieldset that got copied over accidentally.

index.html

cookiecrook · 2023-05-15T21:36:57Z

@scottaohara wrote:

AX API
    AXRole: AXGroup
    AXSubrole: <nil>
    AXRoleDescription: header/footer

Seems reasonable. Checking with others before confirming.

cookiecrook · 2023-05-16T22:48:59Z

@cookiecrook wrote:

[AX API proposals seem] reasonable. Checking with others before confirming.

No comments in 24h. AX API proposals okay as is. Thanks.

index.html

spectranaut

Bear with me as I work out my thoughts on this one because I'm not sure where I land -- whether to introduce these new roles or to leave the distinction between landmark header/footer and not-landmark header/footers in html-aam entirely.

Just to be clear, if this PR lands, the corresponding change in core-aam would be that https://w3c.github.io/html-aam/#el-header and https://w3c.github.io/html-aam/#el-footer point to these new roles and say use these mappings?

I guess one reason why we should introduce these roles is because it is a place to document the concept of a "section header" and "section footer" as apposed to the landmark header/banner and landmaker footer/contentinfo. This makes me feel like there should be some very author-specific guidance about this, and makes me realize we aren't tracking changes to MDN with changes in the spec. Should we be tracking MDN changes? Alternatively, it seems almost too basic, but should there be an APG example for this?

Also, where is the current author facing documentation that says a html header and footer are considered landmarks in these cases and not in these other cases? I just check mdn and it is not there.

Also, would we want a "screen reader guidance" section as well? Essentially explaining you can expose this information when you feel like it's necessary, as @cookiecrook mentioned in the VoiceOver case?

cookiecrook · 2023-05-18T22:15:17Z

Also, would we want a "screen reader guidance" section as well? Essentially explaining you can expose this information when you feel like it's necessary, as @cookiecrook mentioned in the VoiceOver case?

No AT changes are needed on Mac. This is only an engine change that results in a different role description. Nothing more.

On the call today, @scottaohara mentioned the same was true on Windows.

scottaohara · 2023-05-22T17:57:38Z

@spectranaut probably not a bad idea to add a check for has MDN documentation been updated - these docs are often behind the curve with a11y info/updates. header mentions the 'scoped' nature of the header element - lightly, now. footer calls out an old webkit bug in its accessibility section.

scottaohara · 2023-08-16T20:48:17Z

@jnurthen @cookiecrook @spectranaut any other thoughts on this preventing it from merging? got reminded of it when reviewing the (now linked) WPT.

re: author guidance on when a header/footer is a section header/footer vs the landmarks. that can be added to MDN, but that's blocked on this change being made. One could argue the info could be more overtly stated with the current reality of how these elements work. But I would rather make one change than two.

cookiecrook · 2023-08-16T23:09:39Z

@jnurthen @cookiecrook @spectranaut any other thoughts on this preventing it from merging? got reminded of it when reviewing the (now linked) WPT.

re: author guidance on when a header/footer is a section header/footer vs the landmarks. that can be added to MDN, but that's blocked on this change being made. One could argue the info could be more overtly stated with the current reality of how these elements work. But I would rather make one change than two.

I was suggesting the role name be changed from header/footer to sectionheader/sectionfooter to prevent author confusion with the existing role banner…

index.html

scottaohara · 2023-08-16T23:34:54Z

thanks @cookiecrook. for some reason i had a memory of already doing this, but clearly my memory was faulty. i've actually done it now.

spectranaut · 2023-08-17T00:08:49Z

Per our new process, changes to the ARIA spec can't land until there are implementations or implementation commitments, and related changes to the AAMs/Accname, so I think you need to open all those PRs and bugs on browsers.

But I just realized we sort of need an intermediary, because we shouldn't open bugs on browsers until we have "consensus" from the working group... we we need a way of keeping track of that some how. I think it used to be that once we had consensus we merged, and that is how we "kept track" of what had consensus.

scottaohara · 2023-08-17T12:00:51Z

yes, there does seem to be something with this revised process that needs working out, as I didn't think it would make sense to file bugs until reviews were completed (and i did the work james requested and i flubbed on actually doing, until yesterday).

also, as we've already had a few meetings (triage, then the meeting where i actually babbled on about the proposal - resulting in me doing the work, and THEN we did initial triage of the PR) isn't the fact there were reviewers assigned (and anyone else can also review now) the end point of the consensus process? E.g., once we have approving reviews, then that means there is consensus. If more consensus is needed after that, it seems like the process is overcomplicated, or we aren't doing consensus right.

spectranaut · 2023-08-18T20:04:49Z

Ah good point, @scottaohara -- three reviews = consensus. So, we can open issues on implementations after there are three reviews, and we can merge after there is at least one implementation and implementation commitment

spectranaut

I think these sections look good! Very clear description.

related to w3c/aria#1931

spectranaut · 2024-02-22T20:38:55Z

Assigning to myself to make tests and issues on browsers.

This constant has been renamed to `ax::mojom::Role::kSectionFooter`. Chromium change: https://chromium.googlesource.com/chromium/src/+/03a093c456608e8deb9e0c7ce2077f09022ac3f3 commit 03a093c456608e8deb9e0c7ce2077f09022ac3f3 Author: Jocelyn Tran <[email protected]> Date: Fri Aug 16 15:53:13 2024 +0000 [A11y] Rename kHeaderAsNonLandmark and kFooterAsNonLandmark Two new roles are being added to aria: sectionheader and sectionfooter [1]. header scoped to the main element or a sectioning content element will map to sectionheader and footer scoped to the main element or a sectioning content element will map to sectionfooter. There are two existing internal roles, kHeaderAsNonLandmark and kFooterAsNonLandmark, that represent these concepts so only the role name and output strings for the platform APIs have to be updated. [1] w3c/aria#1931 Fixed: 337094897, 358159988, 358192585

scottaohara · 2024-11-15T16:58:01Z

confirming that Edge/Chrome (both msaa/ia2 and uia trees) expose the sectionheader and sectionfooter roles.

scottaohara · 2024-12-09T20:11:34Z

Ah good point, @scottaohara -- three reviews = consensus. So, we can open issues on implementations after there are three reviews, and we can merge after there is at least one implementation and implementation commitment

@spectranaut since this has been implemented in chromium, and the other browsers have their accepted bugs on them, seems we're good to merge per your last comment?

SHA: 80753f9 Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

scottaohara commented May 9, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

jnurthen self-requested a review May 11, 2023 17:11

jnurthen added the Agenda label May 11, 2023

jnurthen requested a review from cookiecrook May 11, 2023 17:12

spectranaut self-requested a review May 11, 2023 19:40

cookiecrook reviewed May 16, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

spectranaut reviewed May 18, 2023

View reviewed changes

spectranaut removed the Agenda label Jun 27, 2023

pkra added this to the ARIA 1.3 milestone Jun 28, 2023

scottaohara mentioned this pull request Aug 16, 2023

breaking out generic (including contextual generic) roles tests to accept implementation variants web-platform-tests/wpt#41392

Merged

scottaohara commented Aug 16, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

scottaohara requested review from cookiecrook and spectranaut October 24, 2023 13:05

scottaohara changed the title ~~add proposed header and footer roles~~ add proposed sectionheader and sectionfooter roles Oct 24, 2023

spectranaut approved these changes Oct 26, 2023

View reviewed changes

scottaohara added a commit to w3c/core-aam that referenced this pull request Oct 26, 2023

mappings for proposed sectionheader/footer

b89d795

related to w3c/aria#1931

scottaohara mentioned this pull request Oct 26, 2023

mappings for sectionheader/footer w3c/core-aam#207

Closed

cookiecrook approved these changes Oct 26, 2023

View reviewed changes

jnurthen approved these changes Feb 22, 2024

View reviewed changes

jnurthen merged commit 80753f9 into main Dec 11, 2024
7 checks passed

jnurthen removed the waiting for implementations Cannot be merged until there are two browser impls or one impl + impl commit label Dec 11, 2024

github-actions bot added a commit that referenced this pull request Dec 11, 2024

add sectionheader and sectionfooter roles (#1931)

d80b89d

SHA: 80753f9 Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add sectionheader and sectionfooter roles #1931

add sectionheader and sectionfooter roles #1931

scottaohara commented May 9, 2023 •

edited by pr-preview bot

Loading

scottaohara left a comment •

edited

Loading

cookiecrook commented May 15, 2023 •

edited

Loading

cookiecrook commented May 16, 2023 •

edited

Loading

spectranaut left a comment

cookiecrook commented May 18, 2023 •

edited

Loading

scottaohara commented May 22, 2023

scottaohara commented Aug 16, 2023 •

edited

Loading

cookiecrook commented Aug 16, 2023 •

edited

Loading

scottaohara commented Aug 16, 2023

spectranaut commented Aug 17, 2023 •

edited

Loading

scottaohara commented Aug 17, 2023 •

edited

Loading

spectranaut commented Aug 18, 2023

spectranaut left a comment

spectranaut commented Feb 22, 2024

scottaohara commented Nov 15, 2024

scottaohara commented Dec 9, 2024

add sectionheader and sectionfooter roles #1931

add sectionheader and sectionfooter roles #1931

Conversation

scottaohara commented May 9, 2023 • edited by pr-preview bot Loading

Implementation tracking

scottaohara left a comment • edited Loading

Choose a reason for hiding this comment

cookiecrook commented May 15, 2023 • edited Loading

cookiecrook commented May 16, 2023 • edited Loading

spectranaut left a comment

Choose a reason for hiding this comment

cookiecrook commented May 18, 2023 • edited Loading

scottaohara commented May 22, 2023

scottaohara commented Aug 16, 2023 • edited Loading

cookiecrook commented Aug 16, 2023 • edited Loading

scottaohara commented Aug 16, 2023

spectranaut commented Aug 17, 2023 • edited Loading

scottaohara commented Aug 17, 2023 • edited Loading

spectranaut commented Aug 18, 2023

spectranaut left a comment

Choose a reason for hiding this comment

spectranaut commented Feb 22, 2024

scottaohara commented Nov 15, 2024

scottaohara commented Dec 9, 2024

scottaohara commented May 9, 2023 •

edited by pr-preview bot

Loading

scottaohara left a comment •

edited

Loading

cookiecrook commented May 15, 2023 •

edited

Loading

cookiecrook commented May 16, 2023 •

edited

Loading

cookiecrook commented May 18, 2023 •

edited

Loading

scottaohara commented Aug 16, 2023 •

edited

Loading

cookiecrook commented Aug 16, 2023 •

edited

Loading

spectranaut commented Aug 17, 2023 •

edited

Loading

scottaohara commented Aug 17, 2023 •

edited

Loading