Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monorepo] re-direct "moved" PRs after merge #2228

Open
2 of 3 tasks
pkra opened this issue May 28, 2024 · 6 comments
Open
2 of 3 tasks

[monorepo] re-direct "moved" PRs after merge #2228

pkra opened this issue May 28, 2024 · 6 comments
Assignees
Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Milestone

Comments

@pkra
Copy link
Member

pkra commented May 28, 2024

When the monorepo branch is merged into the main branch, we will need to redirect the "moved" PRs pointing to the various monorepo branches to point to the main branch.

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label May 28, 2024
@pkra pkra added this to the 2024 milestone May 28, 2024
@pkra pkra self-assigned this May 28, 2024
@pkra
Copy link
Member Author

pkra commented Jun 16, 2024

@spectranaut I thought the idea 3 weeks ago was that the editors of each spec handle the respective issue (review the "moved" PRs, decide on the PRs from forks, then merge your PR to "close" the repository).

Is that no longer the plan? If so, after I merge the "closing" PRs, should the old PRs of each spec stay open (then with merge conflicts to a "blank" spec)?

@pkra
Copy link
Member Author

pkra commented Jul 8, 2024

As per discussion today, I get it now. I'll get on it.

@spectranaut
Copy link
Contributor

Ah yeah sorry I missed your previous comment -- the list I have above is the list with somewhat inactive editors. I guess the specs with active editors can land theirs!

@pkra
Copy link
Member Author

pkra commented Jul 10, 2024

All merged.

@pkra
Copy link
Member Author

pkra commented Jul 10, 2024

It seems only html-aam is left before this issue is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

No branches or pull requests

2 participants