Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore serialization of CDATASection nodes #38

Open
Zirro opened this issue Dec 4, 2018 · 1 comment
Open

Restore serialization of CDATASection nodes #38

Zirro opened this issue Dec 4, 2018 · 1 comment
Labels
xml-serialization

Comments

@Zirro
Copy link

Zirro commented Dec 4, 2018

CDATASection nodes returned to the DOM specification in whatwg/dom#295, and browsers still allow them to be serialized. The serialization steps (which are still present in a comment within this specification) should be restored here as well.
@domenic domenic mentioned this issue Dec 11, 2018
Closed
@TechQuery TechQuery mentioned this issue Dec 12, 2018
Merged
@cscott
Copy link

cscott commented Jul 2, 2021

The serialization steps were in a comment which was removed, but they can still be found at

DOM-Parsing/index.html

Line 1510 in ab8d1ac

<!-- Removing CDATA Serialization steps as this interface type is removed from DOM4

(and in the code for w3c-xmlserializer, which github has helpfully linked above).

Do we need to throw an exception if requireWellFormed is set and the node data contains the string ]]> ? That wasn't in the previous commented-out version of the spec, but it seems consistent.

wmfgerrit pushed a commit to wikimedia/mediawiki-libs-Dodo that referenced this issue Jul 3, 2021
@cscott
Implement XML parser; fixes to XMLSerializer and CDATASection support
4852c2a 
Bug: w3c/DOM-Parsing#29
Bug: w3c/DOM-Parsing#38
Bug: w3c/DOM-Parsing#47
Bug: w3c/DOM-Parsing#48
Bug: w3c/DOM-Parsing#50
Bug: w3c/DOM-Parsing#52
Bug: w3c/DOM-Parsing#59
Bug: w3c/DOM-Parsing#71
Change-Id: I76735c4be1d9738c690417207301f737e3a3c9ff
awesomekling added a commit to awesomekling/ladybird that referenced this issue Nov 19, 2024
@awesomekling
LibWeb: Make Node::is_text() return true for CDATASection nodes
dc74786 
CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: w3c/DOM-Parsing#38
awesomekling added a commit to awesomekling/ladybird that referenced this issue Nov 19, 2024
@awesomekling
LibWeb: Make Node::is_text() return true for CDATASection nodes
a43b0e9 
CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: w3c/DOM-Parsing#38
tcl3 pushed a commit to LadybirdBrowser/ladybird that referenced this issue Nov 19, 2024
@awesomekling @tcl3
LibWeb: Make Node::is_text() return true for CDATASection nodes
6ffc7ea 
CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: w3c/DOM-Parsing#38
gotlougit pushed a commit to gotlougit/ladybird that referenced this issue Nov 21, 2024
@awesomekling @gotlougit
LibWeb: Make Node::is_text() return true for CDATASection nodes
8b59264 
CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: w3c/DOM-Parsing#38
zetslief pushed a commit to zetslief/ladybird that referenced this issue Nov 23, 2024
@awesomekling @zetslief
LibWeb: Make Node::is_text() return true for CDATASection nodes
65f140b 
CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: w3c/DOM-Parsing#38
nico-engels pushed a commit to nico-engels/ladybird that referenced this issue Nov 23, 2024
@awesomekling @nico-engels
LibWeb: Make Node::is_text() return true for CDATASection nodes
9384772 
CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: w3c/DOM-Parsing#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
xml-serialization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cscott @domenic @Zirro