Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define redux-devtools-extension as dependency or peerDependency #33

Open
pburgmer opened this issue Jul 28, 2020 · 3 comments
Open

Define redux-devtools-extension as dependency or peerDependency #33

pburgmer opened this issue Jul 28, 2020 · 3 comments
Assignees

Comments

@pburgmer
Copy link
Collaborator

Tydux uses redux-devtools-extension, e.g. in store.ts. But it neither declares it as dependency or peerDependency.
As of redux itself is declared as peerDependency I would suggest to declare redux-devtools-extension also as peerDependency.

@romanroe romanroe self-assigned this Jul 28, 2020
@sengmann
Copy link
Member

In the actual package.json this package is reverenced as a dependency as follows "redux-devtools-extension": "2.13.8". Should we close this issue or move it to peer-dependencies?

@pburgmer
Copy link
Collaborator Author

pburgmer commented Nov 2, 2020

I'm still pro dev-dependency.

@romanroe
Copy link
Member

romanroe commented Nov 3, 2020

The advantage of peerDependencies that we could declare the dependency but the user could still choose the version, correct? So this should apply to the redux dependency.

The redux-devtools-extension should be listed as devDependency, or shouldn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants