Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DeepPartial for state consumer #28

Open
romanroe opened this issue Feb 29, 2020 · 2 comments
Open

Use DeepPartial for state consumer #28

romanroe opened this issue Feb 29, 2020 · 2 comments
Assignees
@romanroe
Labels
enhancement

Comments

@romanroe
Copy link
Member

No description provided.

@romanroe romanroe self-assigned this Feb 29, 2020
@sengmann
Copy link
Member

@romanroe Do we want to change our implementation? Otherwise I would like to close this issue.

@romanroe
Copy link
Member Author

romanroe commented Dec 22, 2022 •
edited
Loading

@sengmann Currently the Facade#select() returns Observable<Readonly<S>>, which only marks the state's props as readonly (shallow). We should use DeepPartial since the whole state is frozen, not only direct properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romanroe romanroe

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romanroe @sengmann