Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MySQL Advanced Config #472

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

christhemorse
Copy link
Contributor

Description

This PR adds support for Managed Database MySQL advanced configuration options. It also provides a bug fix to the newer printer code that wasn't properly handling all of the different possible data types that could be set.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added bug Something isn't working enhancement New feature or request labels Aug 15, 2024
@christhemorse christhemorse self-assigned this Aug 15, 2024
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @christhemorse, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@optik-aper optik-aper merged commit 1105943 into vultr:master Aug 15, 2024
4 checks passed
@christhemorse christhemorse deleted the mysql-advanced-options branch August 15, 2024 15:06
@optik-aper optik-aper mentioned this pull request Oct 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants