Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the pkg.json scripts #60

Open
louisinger opened this issue Sep 30, 2022 · 2 comments · May be fixed by #77
Open

Simplify the pkg.json scripts #60

louisinger opened this issue Sep 30, 2022 · 2 comments · May be fixed by #77

Comments

@louisinger
Copy link
Collaborator

louisinger commented Sep 30, 2022

  • not sure we need two folders for sources, let's only have ts_src with Typescript sources and drop the duplicate src sources ? The JS files should be generated while we build typescript (in a dist folder) -> similar to what's tsdx do. cc @tiero <- NACK
  • ideally, scripts should be only yarn test, yarn build and yarn format.

Doing that change will be a huge "fork" comparing to bitcoinjs but should be ok to merge next bitcoinjs changes if we keep ts_src and then use our own build process to generate JS files

@tiero
Copy link
Member

tiero commented Sep 30, 2022

nack for dropping the src folder. The BitcoinJS reason is auditability.

@altafan
Copy link
Collaborator

altafan commented Oct 26, 2022

Can this be closed? @tiero @louisinger

@louisinger louisinger changed the title Simplify the pkg.json scripts and drop src folder Simplify the pkg.json scripts Oct 26, 2022
@louisinger louisinger linked a pull request Oct 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants