Refactor the khr_display implementation
#2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cute. |
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* Refactor the `khr_display` implementation * Doc fixes * Move display out of the swapchain module, as it's usable independently
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
This extension is a bit of a mess even in Vulkan form, but I think I managed to do an ok job of it. The trickiest part was ensuring that existing objects are reused when they appear in return values. This is especially problematic with
display_plane_properties, which returns a display handle but doesn't give you any of the other properties of the display. So, the current implementation retrieves the display properties if it finds any are missing, then creates new objects.