Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing barriers when using "Feedback Loop" attachments #2538

Open
Fuzzyzilla opened this issue Jun 25, 2024 · 0 comments
Open

Missing barriers when using "Feedback Loop" attachments #2538

Fuzzyzilla opened this issue Jun 25, 2024 · 0 comments

Comments

@Fuzzyzilla
Copy link
Contributor

  • Version of vulkano: 0.34.1, master
  • OS: Arch
  • GPU (the selected PhysicalDevice): Radeon RX 6600
  • GPU Driver: Mesa 24.1.1
  • Upload of a reasonably minimal complete main.rs file that demonstrates the issue: feedback_loop.rs

Issue

When using feedback loop attachments (the same attachment referenced as both an input and a color attachment within a subpass), race conditions abound without any error from vulkano. Namely, two draw* commands with a pipeline that utilizes a feedback loop are not separated by a vkPipelineBarrier as they should be, confirmed using RenderDoc.

Note that this does not concern a single draw* touching the same sample multiple times, which is still a race condition under this configuration but falls under "general shader unsafety." Instead, multiple distinct draws within the same subpass should not display racing behavior, with barriers inserted between draw commands that write to the attachment and draw commands that read from it.

Results of running feedback_loop.rs on my system: (Expected behavior is a solid green triangle on blue background.)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants