-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linkfix: vitejs/vite-plugin-vue2 #30
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for eager-kowalevski-41f498 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm not sure what the best course of action is here. The current link does work. For anyone using Vue 2.6 I believe that would still be the correct plugin. It's also the plugin shown in the example application. For those using 2.7, the old repo's README does clearly indicate that it is for 2.6, with a link to the newer plugin. If we update the link to the newer plugin then we end up an inconsistency in the example. There's also no indication in the README for that repo that it is a successor to the older plugin. Also, the names of the plugins are different, not just the GitHub repo. The new plugin is called I'm wondering whether the wording here in the migration guide should be changed to provide full context and both links? |
Hi, oh, it's more complicated than I thought... What about:
|
Alternatively we could link to the corresponding section of the Vite docs: https://vitejs.dev/guide/features.html#vue |
I personally suggest keeping the 2.6 as the main case since this is a migration guide. For 2.7 and the official plugin without a existing example to follow, I think we can add one more line behind additionally to describe. What do you folks think? |
I think it's a good idea to link to the Vite docs, as it's a rather complicated situation 😅 Only mentioning the plugin for 2.6 or 2.7 seems inconsistent with other parts of the guide - the webpack guide is about the necessary dependencies to run Vue 3. |
* feat: Ukrainian language * feat: Migration build * feat: Recommendations * feat: Links, breaking changes page * feat: global api * fix: #9 * fix: #10 v-model * #21 translate attr imcludes class and style * #20 Translate: listeners are removed * Update src/uk/breaking-changes/listeners-removed.md * Update src/uk/breaking-changes/listeners-removed.md * Update src/uk/breaking-changes/listeners-removed.md * Update src/uk/breaking-changes/listeners-removed.md * #19 Translate: Slots unification * #18 Translate: render function API * #28 Translate: PropsData * #27 Translate: * #27 Translate: * #26 Translate: inline-template attribute * #25 Translate: filters * Update src/uk/breaking-changes/filters.md * #24 Translate: events API * #23 Translate: keycode modifiers * Update src/uk/breaking-changes/keycode-modifiers.md * Translate: custom elements interop * Translate: custom directives #30 * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <[email protected]> * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <[email protected]> * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <[email protected]> * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <[email protected]> * translation improvements * translate: key Attribute #11 * translate: v-bind merge behavior #13 * translate: v-if vs. v-for precedence #12 * translate: v-on.native modifier removed #14 * translate: title fix #14 * translate: functional components #15 * translate: async components #16 * translate: emits option #17 * translate: attribute coercion behavior #29 * translate: mount changes #32 * translate: props default this access #33 * translate: transition class change #34 * translate: transition as root #35 * translate: transition group root element #36 * translate: vnode lifecycle events #37 * translate: watch on arrays #38 * Update src/uk/breaking-changes/v-if-v-for.md Co-authored-by: Olesya Kogivchak <[email protected]> * Update src/uk/breaking-changes/v-if-v-for.md Co-authored-by: Olesya Kogivchak <[email protected]> * Update src/uk/breaking-changes/key-attribute.md Co-authored-by: Olesya Kogivchak <[email protected]> * Translate: data option --------- Co-authored-by: olesyakogivchak <[email protected]> Co-authored-by: Nazar Niphone <[email protected]> Co-authored-by: Max Druzhinin <[email protected]> Co-authored-by: Olesya Kogivchak <[email protected]>
No description provided.