Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsc): point to shimmed tsc entry point to support ts 5.7 #5020

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

davidmatter
Copy link
Collaborator

@davidmatter davidmatter commented Nov 25, 2024

Typescript 5.7 uses the tsc.js entrypoint for handling the node compile cache. This fix points to the new _tsc.js entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.

Resolves #5018

Typescript 5.7 uses the `tsc.js` entrypoint for handling the node compile cache. This fix points to the new `_tsc.js` entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.
Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5020

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5020

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5020

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5020

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5020

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5020

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5020

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5020

commit: b8befb2

KazariEX
KazariEX previously approved these changes Nov 25, 2024
@rchl
Copy link
Collaborator

rchl commented Nov 25, 2024

Won't that break in older typescript versions instead?

@davidmatter davidmatter marked this pull request as draft November 25, 2024 07:57
@davidmatter
Copy link
Collaborator Author

You're right - that was an early Monday morning PR. Let me have another look

packages/tsc/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Danila Rodichkin <[email protected]>
@ayZagen
Copy link

ayZagen commented Nov 25, 2024

I tried this fix on my pipeline but it throws the following error:

TypeError: Invalid Version: 5.7
 at new SemVer (/app/node_modules/.pnpm/[email protected]/node_modules/semver/classes/semver.js:38:13)
 at compare (/app/node_modules/.pnpm/[email protected]/node_modules/semver/functions/compare.js:3:32)
 at Object.gte (/app/node_modules/.pnpm/[email protected]/node_modules/semver/functions/gte.js:2:30)

@daniluk4000
Copy link
Contributor

Seems like it should be 5.7.0...

zhiyuanzmj
zhiyuanzmj previously approved these changes Nov 26, 2024
@Smrtnyk
Copy link

Smrtnyk commented Dec 1, 2024

what is blocking this PR from being merged?

@bperel
Copy link

bperel commented Dec 2, 2024

what is blocking this PR from being merged?

At least 2 approving reviews are required by reviewers with write access.

KazariEX
KazariEX previously approved these changes Dec 2, 2024
@ujwal-setlur
Copy link

Any idea when this is going to get merged? I feel this is pretty important to get out there.

@FloEdelmann
Copy link
Member

At least 2 approving reviews are required by reviewers with write access.

Since @zhiyuanzmj and @KazariEX have both approved, this requirement is now fulfilled.

@daniluk4000
Copy link
Contributor

@davidmatter could you please resolve lockfile conflicts while we wait?

@ujwal-setlur
Copy link

ujwal-setlur commented Dec 6, 2024

I hate to be a pain on an open source project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been updated for TS 5.7.

@daniluk4000
Copy link
Contributor

I hate to be a pain on an open source project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been updated for TS 5.7.

And this is not the first time this happens here...

Copy link

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with https://github.com/faker-js/playground using

  "pnpm": {
    "overrides": {
      "vue-tsc": "link:../language-tools/packages/tsc"
    }
  }

Works as expected.

@davidmatter davidmatter dismissed stale reviews from KazariEX and zhiyuanzmj via 0484815 December 9, 2024 06:08
@zhiyuanzmj
Copy link
Collaborator

zhiyuanzmj commented Dec 9, 2024

You can use pnpm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@b8befb2 to using it temporarily.

@davidmatter davidmatter merged commit 3fb59af into master Dec 9, 2024
9 checks passed
@davidmatter davidmatter deleted the davidmatter-patch-1 branch December 9, 2024 06:20
@tbsvttr
Copy link

tbsvttr commented Dec 11, 2024

Thanks for all your work! Any idea when a versioned release on npm will follow? At the moment this problem blocks a lot of possible upgrades to TypeScript 5.7 and in a lot of project it is not feasible to add none released package versions as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-tsc doesn't work with typescript 5.7.2