-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tsc): point to shimmed tsc entry point to support ts 5.7 #5020
Conversation
Typescript 5.7 uses the `tsc.js` entrypoint for handling the node compile cache. This fix points to the new `_tsc.js` entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.
vue-component-meta
@vue/language-core
vue-component-type-helpers
@vue/language-plugin-pug
@vue/language-server
vue-tsc
@vue/language-service
@vue/typescript-plugin
commit: |
Won't that break in older typescript versions instead? |
You're right - that was an early Monday morning PR. Let me have another look |
Co-authored-by: Danila Rodichkin <[email protected]>
I tried this fix on my pipeline but it throws the following error:
|
Seems like it should be 5.7.0... |
what is blocking this PR from being merged? |
|
Any idea when this is going to get merged? I feel this is pretty important to get out there. |
Since @zhiyuanzmj and @KazariEX have both approved, this requirement is now fulfilled. |
@davidmatter could you please resolve lockfile conflicts while we wait? |
I hate to be a pain on an open source project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been updated for TS 5.7. |
And this is not the first time this happens here... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with https://github.com/faker-js/playground using
"pnpm": {
"overrides": {
"vue-tsc": "link:../language-tools/packages/tsc"
}
}
Works as expected.
You can use |
Thanks for all your work! Any idea when a versioned release on npm will follow? At the moment this problem blocks a lot of possible upgrades to TypeScript 5.7 and in a lot of project it is not feasible to add none released package versions as a dependency. |
Waiting for vuejs/language-tools#5020.
Typescript 5.7 uses the
tsc.js
entrypoint for handling the node compile cache. This fix points to the new_tsc.js
entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.Resolves #5018