fix(hybridMode): update enabledHybridMode before activate extension #5019

nieyuyao · 2024-11-23T15:16:38Z

the issue seems to only occur when HybridMode is turned off.

the enabledHbridMode variable is initialized to true, but was not updated to the correct value before patching vscode.typescript-language-features.

language-tools/extensions/vscode/src/hybridMode.ts

Line 11 in cf70eda

export const enabledHybridMode = ref<boolean>(true);

language-tools/extensions/vscode/src/nodeClientMain.ts

Lines 150 to 154 in cf70eda

    
           if (!enabledTypeScriptPlugin.value) { 
        
           	text = text.replace( 
        
           		'for(const e of n.contributes.typescriptServerPlugins', 
        
           		s => s + `.filter(p=>p.name!=='vue-typescript-plugin-pack')` 
        
           	);

so, both tsserver and vue language server will respond to completions, and they are duplicated.

pkg-pr-new · 2024-11-23T15:17:18Z

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5019

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5019

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5019

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5019

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5019

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5019

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@5019

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5019

commit: 30c74e5

extensions/vscode/src/hybridMode.ts

fix(hybridMode): update enabledHybridMode before activate extension

c61435e

nieyuyao requested review from johnsoncodehk, so1ve, KazariEX, zhiyuanzmj, KermanX and davidmatter as code owners November 23, 2024 15:16

KazariEX reviewed Nov 23, 2024

View reviewed changes

extensions/vscode/src/hybridMode.ts Outdated Show resolved Hide resolved

fix(hybridMode): modify enabledHybridMode to computed

30c74e5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(hybridMode): update enabledHybridMode before activate extension #5019

fix(hybridMode): update enabledHybridMode before activate extension #5019

nieyuyao commented Nov 23, 2024

pkg-pr-new bot commented Nov 23, 2024 •

edited

Loading

	if (!enabledTypeScriptPlugin.value) {
	text = text.replace(
	'for(const e of n.contributes.typescriptServerPlugins',
	s => s + `.filter(p=>p.name!=='vue-typescript-plugin-pack')`
	);

fix(hybridMode): update enabledHybridMode before activate extension #5019

Are you sure you want to change the base?

fix(hybridMode): update enabledHybridMode before activate extension #5019

Conversation

nieyuyao commented Nov 23, 2024

pkg-pr-new bot commented Nov 23, 2024 • edited Loading

pkg-pr-new bot commented Nov 23, 2024 •

edited

Loading