Fix version and update dependencies #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 27, 2024 12:15
zugao
requested review from
a team,
Kidswiss,
TheBigLee and
wejdross
and removed request for
a team
Kidswiss
requested changes
May 28, 2024
| 1. `export EXOSCALE_API_KEY=<the-key>` | ||
| 1. `export EXOSCALE_API_SECRET=<the-secret>` | ||
| 1. `make local-install` | ||
| 2. `export EXOSCALE_API_KEY=<the-key>` |
There was a problem hiding this comment.
No need to manually increment here. Most markdown renderers will do that for you.
There was a problem hiding this comment.
Well as you can see the previous markdown didn't work quite well lol :D
There was a problem hiding this comment.
The current readme shows fine for me though?
https://github.com/vshn/provider-exoscale/blob/master/README.md#quickstart-demonstration
Be aware that the source code will not automatically increment the numbering, it's only in the rendered version.
But anyway it's just a nitpick.
added 2 commits
May 28, 2024 10:33
Kidswiss
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
make test-e2elocally.bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.