Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using --tag tags are not pushed #162

Closed
Raskil opened this issue Nov 28, 2018 · 4 comments
Closed

when using --tag tags are not pushed #162

Raskil opened this issue Nov 28, 2018 · 4 comments

Comments

@Raskil
Copy link

Raskil commented Nov 28, 2018

Hi,

when using the --tags option, tags are not pushed to remote, because the remote.push method used, does not specify { :tags => true } option. And the push method for tags does not specify a branch. So this will fail if there is no master branch present (which is the default for ruby-git).

Regards

Raskil

@bastelfreak
Copy link
Member

Hi @Raskil, thanks for reporting this. Are you able to provide a patch?

@Raskil
Copy link
Author

Raskil commented Nov 28, 2018

@bastelfreak It depends. I've a patched version avaiable, where I extended the bump and tag methods to accept branch and push options as additional parameters. But it feels more or less like a dirty hack, because I've to duplicate some values/some code of the update methode for it. It will fix #161 as well.
I could toss a PR, but it feels like it would be better to structure the repo.push calls and the options handling for it better.

@Raskil Raskil changed the title when using --tag tags a not pushed when using --tag tags are not pushed Nov 28, 2018
@ekohl
Copy link
Member

ekohl commented Dec 5, 2018

Personally I'm a fan of git push --follow-tags and let git push all annotated tags that are also on the remote. Thoughts about using this?

@ekohl
Copy link
Member

ekohl commented Jul 20, 2020

Closing for inactivity.

@ekohl ekohl closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants